Review Request 118785: Segment Axis object in KIG ( GSoC 14 )

Aniket Anvit seeanvit at gmail.com
Thu Jun 19 05:07:25 UTC 2014



> On June 18, 2014, 5:05 p.m., Maurizio Paolini wrote:
> > The old segment_axis macro required as argument a segment, whereas the new construction
> > depends on two points... this could lead to some confusion, and actually, the name
> > SegmentAxisABType is a little bit incorrect.
> > A user that is accustomed to the old segment_axis would find the use of the new 
> > SegmentAxisABType different.
> > Question: what is the reason to add this new construction?

The macro one could only construct the perpendicular bisector for segments. Since the object one takes two points as inputs, it can construct the perpendicular-bisector of any two points ( even if there is no segment constructed with them ). Also, perpendicular-bisector is an important constructionso we should have it directly implemented as an object rather than as a built-in macro. It will be better...


- Aniket


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118785/#review60377
-----------------------------------------------------------


On June 18, 2014, 2:25 p.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118785/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 2:25 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch adds the segment axis object to KIG. This new object will take two points as input and generates a line which would perpendicularly bisect the segment constructed with those two points.
> 
> 
> Diffs
> -----
> 
>   macros/CMakeLists.txt 8abf249 
>   macros/segment_axis.kigt e86b90c 
>   misc/builtin_stuff.cc 28846c8 
>   objects/line_type.h 3ea252b 
>   objects/line_type.cc dbf575c 
> 
> Diff: https://git.reviewboard.kde.org/r/118785/diff/
> 
> 
> Testing
> -------
> 
> Took 6 points and constructed the perpendicular-bisectors choosing random pair. Tested with semgents too.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140619/622fb929/attachment.html>


More information about the kde-edu mailing list