Review Request 118735: Port libkeduvocdocument from KUrl to QUrl

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118735/#review60432
-----------------------------------------------------------



keduvocdocument/keduvockvtml2writer.cpp
<https://git.reviewboard.kde.org/r/118735/#comment42169>

    Better if it is '/', also for the rest



keduvocdocument/tests/converter.cpp
<https://git.reviewboard.kde.org/r/118735/#comment42168>

    Already a QUrl, if you convert it, it won't work then. Or does it? Have you tried the test? :D


- Aleix Pol Gonzalez


On June 18, 2014, 5:49 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118735/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 5:49 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.
> 
> 
> Repository: libkdeedu
> 
> 
> Description
> -------
> 
> KUrl is deprecated in frameworks, so I've ported libkeduvocdocument away from it, to QUrl.
> I also changed the top CMakeLists.txt frameworks version so it will build against frameworks from master branches.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvocexpression.cpp 343bc73 
>   keduvocdocument/keduvocdocument.cpp 878ccbf 
>   keduvocdocument/keduvocdocument.h a312fc1 
>   keduvocdocument/keduvoccontainer.cpp 23db0fb 
>   keduvocdocument/keduvoccontainer.h 0fc550b 
>   keduvocdocument/autotests/keduvocdocumentvalidatortest.cpp 781bdfa 
>   CMakeLists.txt 21696ef 
>   keduvocdocument/keduvockvtml2reader.h 39545f3 
>   keduvocdocument/keduvockvtml2reader.cpp 0d0c639 
>   keduvocdocument/keduvockvtml2writer.cpp 2a043cf 
>   keduvocdocument/keduvoctranslation.h a836a77 
>   keduvocdocument/keduvoctranslation.cpp 1d7a5eb 
>   keduvocdocument/sharedkvtmlfiles.cpp a5f45a2 
>   keduvocdocument/tests/converter.cpp 126334c 
> 
> Diff: https://git.reviewboard.kde.org/r/118735/diff/
> 
> 
> Testing
> -------
> 
> It still builds, haven't tried the tests, but I don't think the autotests cover this.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140618/08dccb5b/attachment.html>