Review Request 118621: Fix crash when 3rd language added to new collection and grammar is downloaded

Andreas Xavier andxav at zoho.com
Wed Jun 18 16:32:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118621/
-----------------------------------------------------------

(Updated June 18, 2014, 4:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Repository: parley


Description
-------

If this is an inappropriate location for the submission of a bug report with patch against the master branch of the git repo for parley, then please inform me and I will submit it in the appropriate location.

Bug Report:  

1. Start Parley
2. Create New Collection. 
3. Click OK
4. Add Language.
5. Download new grammar.  (for the new 3rd language)
6. Crash.

Patch:

Add a new identifier to the kvocdoc if there are fewer languages that the requested number.


Diffs
-----

  src/settings/languageproperties.cpp ed281dc 

Diff: https://git.reviewboard.kde.org/r/118621/diff/


Testing
-------

Repeated the above steps and no crash.


Thanks,

Andreas Xavier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140618/28cd1591/attachment.html>


More information about the kde-edu mailing list