Review Request 118622: Dual-direction training always uses unknown language for mixed letter and multiple choice practice modes.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118622/#review60371
-----------------------------------------------------------


This review has been submitted with commit b784f5b210daa1393f33b796b7ca9d5212f4c3ef by Inge Wallin on behalf of Andreas Xavier to branch master.

- Commit Hook


On June 9, 2014, 7:09 a.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118622/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 7:09 a.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> If this is not the correct location for this patch, please inform me and I will submit it elsewhere.
> 
> If ingwa is not finished implementing this feature and I am stepping on toes, then please ignore this request.
> 
> Otherwise.
> 
> The recently implemented useful feature dual-direction training always uses the unknown language for the answer for
> the mixed letter practice mode, when the mixed letter hint implies the known language is the answer.  
> Additionally, for multiple choice all of the incorrect options are in the unknown language
> even when the answer is in the known language.
> 
> The patch uses currentEntry->languageTo() to select both the correct answer for written answers and the correct options for multiple choice questions. 
> 
> 
> Diffs
> -----
> 
>   src/practice/sessionmanagerbase.cpp db9e372 
>   src/practice/writtenpracticevalidator.h 0bea4e1 
>   src/practice/writtenpracticevalidator.cpp c45a40b 
> 
> Diff: https://git.reviewboard.kde.org/r/118622/diff/
> 
> 
> Testing
> -------
> 
> Played the game to verify both directions worked.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140618/29e86427/attachment.html>