Review Request 118621: Fix crash when 3rd language added to new collection and grammar is downloaded

[Andreas Xavier]

> On June 17, 2014, 12:46 p.m., Inge Wallin wrote:
> > Looks good.  You can push it if you have the credentials, otherwise I can do it for you.
> > 
> > If this bug is also present in Parley for KDE release 4.13 then the way we normally use is to add the patch to 4.13 and then forward merge it into master. Refer to Andreas Cord-Landwehr (cola) if you need instructions on how to do this in git.

I do not have credentials, so I would be grateful if you commit it for me.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118621/#review60238
-----------------------------------------------------------


On June 9, 2014, 6:42 a.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118621/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 6:42 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> If this is an inappropriate location for the submission of a bug report with patch against the master branch of the git repo for parley, then please inform me and I will submit it in the appropriate location.
> 
> Bug Report:  
> 
> 1. Start Parley
> 2. Create New Collection. 
> 3. Click OK
> 4. Add Language.
> 5. Download new grammar.  (for the new 3rd language)
> 6. Crash.
> 
> Patch:
> 
> Add a new identifier to the kvocdoc if there are fewer languages that the requested number.
> 
> 
> Diffs
> -----
> 
>   src/settings/languageproperties.cpp ed281dc 
> 
> Diff: https://git.reviewboard.kde.org/r/118621/diff/
> 
> 
> Testing
> -------
> 
> Repeated the above steps and no crash.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140618/f208f526/attachment.html>