Review Request 118785: Perpendicular Bisector object in KIG ( GSoC 14 )

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118785/#review60219
-----------------------------------------------------------


If this is implementing the perpendicular bisector, it should be replacing the segment_axis macro, which I don't see handled here. I would expect this patch to remove that macro, and whatever calls that macro when you want to create a perpendicular bisector right now in Kig, and test accordingly.

- David Narváez


On June 17, 2014, 4:32 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118785/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 4:32 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch adds the perpendicular-bisector object to KIG. This new object will take two points as input and generates a line which would perpendicularly bisect the segment constructed with those two points.
> 
> 
> Diffs
> -----
> 
>   kig/kigpartui.rc a99f246 
>   misc/builtin_stuff.cc 28846c8 
>   objects/line_type.h 3ea252b 
>   objects/line_type.cc dbf575c 
> 
> Diff: https://git.reviewboard.kde.org/r/118785/diff/
> 
> 
> Testing
> -------
> 
> Tool 6 points and constructed the perpendicular-bisectors choosing random pair.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140617/02a56866/attachment.html>