Review Request 118611: Add Ctrl+Space as alternative code completion command in Cantor worksheet

Alexander Rieder alexanderrieder at gmail.com
Sun Jun 8 09:28:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118611/#review59543
-----------------------------------------------------------


I think this is the wrong place for this change. As far as I remember this code is only there to free up tab for KActions. Could you look for the respective kaction(somewhere in worksheet or the part I guess) and set the default there? (This keeps things consistent with what you change from the gui option)

- Alexander Rieder


On June 8, 2014, 12:53 a.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118611/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 12:53 a.m.)
> 
> 
> Review request for KDE Edu and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Cantor have a new code completion feature in script editor [http://blog.filipesaraiva.info/?p=1275]. This code completion is activated typing Ctrl+Space. But in Cantor worksheet the code completion is activated typing TAB key.
> 
> This patch add Ctrl+Space as a command to activate code completion in Cantor worksheet. Then Cantor worksheet will have two default command to this feature: TAB key (for historical reasons) and Ctrl+Space.
> 
> 
> Diffs
> -----
> 
>   src/worksheettextitem.cpp fef2c33 
> 
> Diff: https://git.reviewboard.kde.org/r/118611/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140608/d8a57ef0/attachment.html>


More information about the kde-edu mailing list