Review Request 118295: support for Geogebra's conics in KIG ( GSoC 14 )

David Narváez david.narvaez at computer.org
Fri Jun 6 02:17:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118295/#review59367
-----------------------------------------------------------

Ship it!


Perfect patch :D please commit (please use http://techbase.kde.org/Development/Git/Configuration#Commit_Template with the proper REVIEW field etc) and discard the other conic reviews

- David Narváez


On June 5, 2014, 4:59 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118295/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 4:59 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch enables KIG to read all conic type ( conic-5-points, ellipse-foci-and-point, hyperbola-foci-and-point, parabola-line-point ) objects from Geogebra worksheets.
> 
> 
> Diffs
> -----
> 
>   filters/geogebra-filter.cpp aaa2087 
>   filters/geogebra.xsl e52fc1d 
> 
> Diff: https://git.reviewboard.kde.org/r/118295/diff/
> 
> 
> Testing
> -------
> 
> Opened a Geogebra worksheet containing 2 objects of each conic type.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140606/afc0e4fb/attachment.html>


More information about the kde-edu mailing list