Review Request 118453: Perform the switch of terms that were agreed for the language applications

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118453/#review59010
-----------------------------------------------------------


All changes look fine, except some capitalization issues. The HIG, http://techbase.kde.org/Projects/Usability/HIG/Capitalization, says that for menu items and buttons title capitalization shall be used.
Also there is a minor issues about a remove shortcut.
According to the performed changes, updates to the handbook become necessary too, I think.


src/editor/FromToEntryPage.cpp
<https://git.reviewboard.kde.org/r/118453/#comment41033>

    "Confidence Levels from %1 to %2"



src/editor/FromToEntryPageForm.ui
<https://git.reviewboard.kde.org/r/118453/#comment41034>

    "Confidence Level:"



src/editor/FromToEntryPageForm.ui
<https://git.reviewboard.kde.org/r/118453/#comment41035>

    "Reset Confidence Levels"



src/parleyactions.cpp
<https://git.reviewboard.kde.org/r/118453/#comment41032>

    use title capitalization: "Remove Confidence Levels"



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/118453/#comment41036>

    it becomes a menu item -> HIG says the string should use title capitalization:
    "Remove Confidence Levels From This Unit"



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/118453/#comment41037>

    * use title capitalization
    * the G shortcut was removed (might also have to be updated in the handbook)



src/vocabulary/lessonview.cpp
<https://git.reviewboard.kde.org/r/118453/#comment41038>

    use title capitalization



src/vocabulary/lessonview.cpp
<https://git.reviewboard.kde.org/r/118453/#comment41039>

    use title capitalization



src/vocabulary/lessonview.cpp
<https://git.reviewboard.kde.org/r/118453/#comment41040>

    use title capitalization



src/vocabulary/lessonview.cpp
<https://git.reviewboard.kde.org/r/118453/#comment41041>

    use title capitalization


- Andreas Cord-Landwehr


On June 1, 2014, 10:09 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118453/
> -----------------------------------------------------------
> 
> (Updated June 1, 2014, 10:09 p.m.)
> 
> 
> Review request for KDE Edu and Amarvir Singh.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This patch does the change of terms that we agreed on.
> Specifically: 
>  Lesson -> Unit
>  Grade  -> Confidence
> 
> 
> Diffs
> -----
> 
>   src/editor/FromToEntryPage.cpp 7833ad6 
>   src/editor/FromToEntryPageForm.ui 1536d18 
>   src/editor/editor.cpp 415f27b 
>   src/parleyactions.cpp beaa8bd 
>   src/practice/answervalidatorold.cpp b15377f 
>   src/practice/entryfilter.cpp 59f9425 
>   src/practice/guifrontend.cpp 4b3ca31 
>   src/practice/practice_mainwindow.ui 57e7bd7 
>   src/scripts/scripting/parley.h 7ceb280 
>   src/settings/parley.kcfg da3f2bc 
>   src/statistics/lessonstatistics.cpp 1a1232c 
>   src/statistics/statisticsmainwindow.cpp 7845e79 
>   src/statistics/statisticsmodel.cpp 7053cc8 
>   src/vocabulary/containermodel.cpp 22b7754 
>   src/vocabulary/leitnerview.cpp d2f359f 
>   src/vocabulary/lessonview.h da77ba9 
>   src/vocabulary/lessonview.cpp e7d6cd3 
>   src/vocabulary/vocabularymodel.cpp 2b52029 
> 
> Diff: https://git.reviewboard.kde.org/r/118453/diff/
> 
> 
> Testing
> -------
> 
> No testing, these are string changes only.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140602/68f08fe0/attachment-0001.html>