Review Request 118942: support for gogebra's tools in kig ( GSoC 14 )

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118942/#review62705
-----------------------------------------------------------


Almost there! Just this set of tiny changes and should be good to go.


filters/geogebra-filter.cpp
<https://git.reviewboard.kde.org/r/118942/#comment43461>

    Delete this blank line



geogebra/geogebrasection.h
<https://git.reviewboard.kde.org/r/118942/#comment43465>

    Same as in the header of the .cpp



geogebra/geogebrasection.h
<https://git.reviewboard.kde.org/r/118942/#comment43462>

    Better do a search/replace of GEOGEBRA_SECTION_H to GEOGEBRASECTION_H in this file, for consistency



geogebra/geogebrasection.cpp
<https://git.reviewboard.kde.org/r/118942/#comment43463>

    Fix the description of the file to GeogebraSection class and then put your name and e-mail in the copyright, this is your class :)



geogebra/geogebratransformer.h
<https://git.reviewboard.kde.org/r/118942/#comment43466>

    Fix the description of this file to GeogebraTransformer class



geogebra/geogebratransformer.h
<https://git.reviewboard.kde.org/r/118942/#comment43467>

    Fix the year



geogebra/geogebratransformer.h
<https://git.reviewboard.kde.org/r/118942/#comment43468>

    Here also better search/replace with GEOGEBRATRANSFORMER_H



geogebra/geogebratransformer.h
<https://git.reviewboard.kde.org/r/118942/#comment43470>

    Looks like this one is not needed



geogebra/geogebratransformer.cpp
<https://git.reviewboard.kde.org/r/118942/#comment43469>

    Match the header with the changes in the .h file


- David Narváez


On July 19, 2014, 4:56 p.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118942/
> -----------------------------------------------------------
> 
> (Updated July 19, 2014, 4:56 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch adds support for Geogebra's tool files ( .ggt files ) in kig.
> 
> 
> Diffs
> -----
> 
>   modes/typesdialog.cpp d14d0fe 
>   CMakeLists.txt 4b2d286 
>   geogebra/geogebratransformer.h PRE-CREATION 
>   geogebra/geogebratransformer.cpp PRE-CREATION 
>   modes/typesdialog.h ae245e2 
>   geogebra/geogebrasection.cpp PRE-CREATION 
>   filters/geogebra-filter.h 1b2b416 
>   filters/geogebra-filter.cpp 53c9253 
>   filters/geogebra.qrc bfe493a 
>   filters/geogebra.xsl a0809da 
>   geogebra/geogebra.qrc PRE-CREATION 
>   geogebra/geogebra.xsl PRE-CREATION 
>   geogebra/geogebrasection.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118942/diff/
> 
> 
> Testing
> -------
> 
> To open a tool file, open them from the types-dialog.
> I tested with a tool which takes 2 points and gives a line , midpoint, and a circle from these two points.
> Tested with another tool which took three points and gave a circle, hyperbola and an ellipse from these points.
> Only those tools will be supported which contain only the geogebra-objects which are currently supported by kig.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140719/67a0eb2c/attachment.html>