Review Request 118942: support for gogebra's tools in kig ( GSoC 14 )

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118942/#review62700
-----------------------------------------------------------



geogebra/geogebra-transformer.h
<https://git.reviewboard.kde.org/r/118942/#comment43455>

    Move this class and its implementation to geogebrasection.{h,cpp} files. And while you are at it, rename geogebra-transformer.{h,cpp} to geogebratransformer.{h,cpp}, I think the convention everywhere else (but in the filters) is without the -.


- David Narváez


On July 19, 2014, 11:22 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118942/
> -----------------------------------------------------------
> 
> (Updated July 19, 2014, 11:22 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch adds support for Geogebra's tool files ( .ggt files ) in kig.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4b2d286 
>   filters/geogebra-filter.h 1b2b416 
>   filters/geogebra-filter.cpp 53c9253 
>   filters/geogebra.qrc bfe493a 
>   filters/geogebra.xsl a0809da 
>   geogebra/geogebra-transformer.h PRE-CREATION 
>   geogebra/geogebra-transformer.cpp PRE-CREATION 
>   geogebra/geogebra.qrc PRE-CREATION 
>   geogebra/geogebra.xsl PRE-CREATION 
>   modes/typesdialog.h ae245e2 
>   modes/typesdialog.cpp d14d0fe 
> 
> Diff: https://git.reviewboard.kde.org/r/118942/diff/
> 
> 
> Testing
> -------
> 
> To open a tool file, open them from the types-dialog.
> I tested with a tool which takes 2 points and gives a line , midpoint, and a circle from these two points.
> Tested with another tool which took three points and gave a circle, hyperbola and an ellipse from these points.
> Only those tools will be supported which contain only the geogebra-objects which are currently supported by kig.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140719/72257770/attachment.html>