Review Request 118942: support for gogebra's tools in kig ( GSoC 14 )

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118942/#review62665
-----------------------------------------------------------


Can you confirm the imported tools work as expected? I imported two tools and they are loaded OK (good names, good descriptions) but the tools themselves are probably not working (although I can't remember what my tools did :P). I have an argument against dropping the ReadingSection state, but lets not worry about that for now, we can add it later if needed.

Re: GCC, don't bother with GCC 3.4, that's very old. Let's keep track of GCC >=4.5. If it helps, I have GCC 4.7 to 4.9 so I can test any of those if you don't have them. I can also test Clang eventually.

Please update the description of the patch, since the old description says you don't open these tools from the Types dialog.


geogebra/geogebra-transformer.h
<https://git.reviewboard.kde.org/r/118942/#comment43438>

    Let's have a proper GeogebraSection class with m_name, setName( const QString & name ) and getName() const methods, same for descriptions. It will also have std::vector<ObjectCalcer *> m_inputObjects and another vector of output objects (what's currently .first and .second).



modes/geogebra_tool_filter.cpp
<https://git.reviewboard.kde.org/r/118942/#comment43436>

    Lets move all of this into the TypesDialog class as a loadGeogebraTools method



modes/typesdialog.cpp
<https://git.reviewboard.kde.org/r/118942/#comment43437>

    Could you add a //TODO comment about the MIME types here? That's something I need to take care of


- David Narváez


On July 18, 2014, 12:48 p.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118942/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 12:48 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch adds support for Geogebra's tool files ( .ggt files ) in kig.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4b2d286 
>   filters/geogebra-filter.h 1b2b416 
>   filters/geogebra-filter.cpp 53c9253 
>   filters/geogebra.qrc bfe493a 
>   filters/geogebra.xsl a0809da 
>   geogebra/geogebra-transformer.h PRE-CREATION 
>   geogebra/geogebra-transformer.cpp PRE-CREATION 
>   geogebra/geogebra.qrc PRE-CREATION 
>   geogebra/geogebra.xsl PRE-CREATION 
>   modes/geogebra_tool_filter.h PRE-CREATION 
>   modes/geogebra_tool_filter.cpp PRE-CREATION 
>   modes/typesdialog.cpp d14d0fe 
> 
> Diff: https://git.reviewboard.kde.org/r/118942/diff/
> 
> 
> Testing
> -------
> 
> To open a tool file, open them from the open-file dialog ( and not from the types-dialog ).
> I tested with a tool which takes 2 points and gives a line , midpoint, and a circle from these two points.
> Tested with another tool which took three points and gave a circle, hyperbola and an ellipse from these points.
> Only those tools will be supported which contain only the geogebra-objects which are currently supported by kig.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140718/08a14863/attachment-0001.html>