Review Request 119167: Rename libkdeedu to libkeduvocdocument in cmake files

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jul 7 23:11:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119167/#review61864
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/119167/#comment43080>

    Maybe it's a good moment to give it a readable name?


The rest of the patch looks good by the way, just thought I'd annoy a bit. ;)

- Aleix Pol Gonzalez


On July 7, 2014, 10:09 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119167/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 10:09 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez, Inge Wallin, and Nicolás Alvarez.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> Since libkdeedu is now only libkeduvocdocument (once the icons move) I've renamed the cmake config and targets files.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c92d82e 
>   LibKdeEduConfig.cmake.in bab430b 
>   LibKeduVocDocumentConfig.cmake.in PRE-CREATION 
>   Mainpage.dox 280c349 
>   README 0564d3e 
>   keduvocdocument/CMakeLists.txt 81717c9 
> 
> Diff: https://git.reviewboard.kde.org/r/119167/diff/
> 
> 
> Testing
> -------
> 
> It builds and installs here.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140707/8f588c78/attachment.html>


More information about the kde-edu mailing list