Review Request 118895: Feature: Add default unittest setup to parley.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118895/#review61689
-----------------------------------------------------------

Ship it!


Seems to work.  But please fix the formatting issues before committing.

Very good start for the unit tests!


autotests/parleyunittestutilities.cpp
<https://git.reviewboard.kde.org/r/118895/#comment42931>

    This patch was so good that I hate to add a comment. :)
    
    But we always start all functions with the opening brace on a new line according to the coding standards.


- Inge Wallin


On June 23, 2014, 6:34 a.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118895/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 6:34 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This is a developer directed new feature.  There are no user visible changes.
> 
> This creates 2 stub unittests in the autotest directory so that devs can easily add new unit tests of classes without doing the setup in this patch.
> 
> It moves the definition of parley's include directories and link libraries up into the root CMake file so that they are visible to the unittests and only need to be redefined in one location when a dev makes a change elsewhere.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b741dc4 
>   autotests/CMakeLists.txt PRE-CREATION 
>   autotests/allpass1test.cpp PRE-CREATION 
>   autotests/allpass2test.cpp PRE-CREATION 
>   autotests/parleyunittestutilities.h PRE-CREATION 
>   autotests/parleyunittestutilities.cpp PRE-CREATION 
>   src/CMakeLists.txt a2da378 
> 
> Diff: https://git.reviewboard.kde.org/r/118895/diff/
> 
> 
> Testing
> -------
> 
> unittests
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140706/7540a3cb/attachment-0001.html>