Review Request 119125: bugifx 333076: parley and dolphin crash simultaneously when images are dragged from dolphin to parley

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119125/#review61677
-----------------------------------------------------------

Ship it!


Looks good to me.  Two things, though:
 - Check my comment in the diff. It's a comment about the old code but it has an effect on the new code.
 - Please comment out all the kDebug()'s before you commit

Just fix or comment on those and you can commit.  No further review necessary.


src/editor/imagechooserwidget.cpp
<https://git.reviewboard.kde.org/r/119125/#comment42922>

    Are you sure this is 100% safe? A dynamic_cast<> followed by a test against 0 sounds much safer to me.


- Inge Wallin


On July 5, 2014, 10:10 a.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119125/
> -----------------------------------------------------------
> 
> (Updated July 5, 2014, 10:10 a.m.)
> 
> 
> Review request for KDE Edu, Ian Monroe, Inge Wallin, and Jeremy Whiting.
> 
> 
> Bugs: 333076
>     http://bugs.kde.org/show_bug.cgi?id=333076
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Problem: Some dragdrop events don't contain any urls.  The previous code assumed that all events contain at least one url and would crash when it accessed the non-existent QList[0] item.
> 
> Patch:  Checks that there is at least 1 url before using the first url.
> 
> Note: I was unable to crash dolphin, but I think this is the same bug because the crash occurs on the exact same line as in Ansa's backtrace.
> 
> 
> Diffs
> -----
> 
>   src/editor/imagechooserwidget.cpp 957581b 
> 
> Diff: https://git.reviewboard.kde.org/r/119125/diff/
> 
> 
> Testing
> -------
> 
> It is a gui bug, so no unit tests.
> 
> I generated the crashes by swirling the mouse around with an image ready to drop on parley editor, until it generated an empty event and crashed Parley.
> 
> I tested by swirling the mouse around until I saw debug messages indicating that empty drop events had been ignored. 
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140706/b898b8a8/attachment.html>