Review Request 114919: Port away answersDialog from KDialog in KGeography

[David Gil Oliva]

> On Jan. 9, 2014, 9:21 p.m., Albert Astals Cid wrote:
> > Looks good.
> > 
> > Not related to this patch, please have a look at the part of the code that draws the "Correct answers" label on the left sidebar of the main widget since something has regressed there over the kde4 version, when you switch to more than 10 answers the text gets cut.

kgeography.cpp was my next porting and refactoring target, so after the work I will check that it works and looks as expected, and otherwise I will fix it.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114919/#review47127
-----------------------------------------------------------


On Jan. 8, 2014, 11:18 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114919/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 11:18 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Port away from KDialog. Some refactoring. Fix indentation.
> 
> 
> Diffs
> -----
> 
>   src/answersdialog.h d2c0f92 
>   src/answersdialog.cpp d412b1a 
> 
> Diff: https://git.reviewboard.kde.org/r/114919/diff/
> 
> 
> Testing
> -------
> 
> It builds. It works as expected.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140109/aca2c5d4/attachment.html>