Review Request 114919: Port away answersDialog from KDialog in KGeography

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jan 8 23:27:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114919/#review47092
-----------------------------------------------------------


I don't see anything wrong, but then there are many changes, so I'll let Albert to do the Ship It! :)

- Aleix Pol Gonzalez


On Jan. 8, 2014, 11:18 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114919/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 11:18 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Port away from KDialog. Some refactoring. Fix indentation.
> 
> 
> Diffs
> -----
> 
>   src/answersdialog.h d2c0f92 
>   src/answersdialog.cpp d412b1a 
> 
> Diff: https://git.reviewboard.kde.org/r/114919/diff/
> 
> 
> Testing
> -------
> 
> It builds. It works as expected.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140108/2e07d4e9/attachment.html>


More information about the kde-edu mailing list