Review Request 114581: First step to port to KF5

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114581/#review46954
-----------------------------------------------------------


This review has been submitted with commit 1b7772ffc36c0b7342731bed454326e0905a83f0 by David Gil to branch frameworks.

- Commit Hook


On Jan. 6, 2014, 11:34 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114581/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 11:34 p.m.)
> 
> 
> Review request for KDE Edu, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> First step to port to KF5
> 
> It builds and it works fairly well. But:
> --There still are some KDE4 classes to port away from.
> --Some toolbar buttons don't show up.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e7a6d9cbaa66871793854d2e6b17a3f7ce837324 
>   doc/CMakeLists.txt 9752e88cd95133006dbf44ef039eb9ee08111e56 
>   src/CMakeLists.txt 9e49f0d673d8fcc9df3c4ecc3f4ff5c88d0b307a 
>   src/answersdialog.cpp b64c07ac76ee80994fa458eae0e507cad0234494 
>   src/askwidget.cpp 7f9e3cc5fd08aa5869d0545cb09cb4310dea0f2d 
>   src/boxasker.h 507099f5fe0842caa7653af6c49e961f023dc150 
>   src/boxasker.cpp f0a5b608db1d23492f9175256f448f125b1ce57c 
>   src/capitaldivisionasker.cpp 495eb26f813c5a69e07d7703a0cbefaa8b5cbb7a 
>   src/divisioncapitalasker.cpp 625379b6022a03a610aa8819fabaf6230d9c5982 
>   src/divisionflagasker.cpp 361c97396372cd5a1a0668803bd190615fdb338f 
>   src/flagdivisionasker.cpp 34f7711b8e02061a3224dfd4f2a45601afc6e019 
>   src/integerinputdialog.h bef021de21612d031a7d372e52a41a731a0e97cf 
>   src/integerinputdialog.cpp c2243dc9a3fb9aa2e2f02cb1ecf3d8d3cc3b049a 
>   src/kgeography.h 4506bd0c09f13ce39f79735091ac375353842136 
>   src/kgeography.cpp e5e53050f5b70d8f467061d0bf2bce0e36f32691 
>   src/kgeographyoptions.ui 109b0778642f1d92fd84909b709efed7c83e5b14 
>   src/main.cpp 99273ff29a846aa68a105fd7b95e9a85982c8e28 
>   src/map.cpp e8f1e7f77895efe86d6d7620a0008f28e8845951 
>   src/mapasker.cpp 22e0c246187cd0bbd6aac4895f4bda325e43a93a 
>   src/mapchooser.cpp a795fe7b2b539db4f7cda104e03688f3d0de5ad2 
>   src/mapparser.cpp 126d516a1c5178539a037dff58485e59b63eea03 
>   src/mapwidget.cpp 77b653a0a20af091f1f577c46581f99f197ac163 
>   src/mypopup.cpp 939c982a55fa858d71976f9808beac89a7aa1640 
>   src/placeasker.cpp d65e0305191e3104b938deffa3802f6d3b6a6118 
>   src/placemapwidget.cpp 00675839adf33cf6359ddcbc4958f53c3e3cedf9 
> 
> Diff: https://git.reviewboard.kde.org/r/114581/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140107/eb22a519/attachment-0001.html>