Review Request 116095: Loading images with Parley Google images plugin's in-built screen scraper fails - using Google JSON AJAX API instead

[Amarvir Singh]

> On Feb. 28, 2014, 9:22 p.m., Amarvir Singh wrote:
> > Thank you for the patch. But, there were a few conflicts. So, please perform a 'rebase' after 'pulling' the latest changes and then send an updated patch. Also, I'd recommend using git diff or git format-patch. Easier to use and apply :)
> 
> Yuri Chornoivan wrote:
>     In fact, the current code does load the images (but pre 4.11 versions do not):
>     
>     https://git.reviewboard.kde.org/r/112285/
>     
>     Though this approach may be better, it implicitly add dependencies on var_dump Python package (not available for all distributions).

Oh, I wasn't aware of that. But, I tried using the 'Fetch Image' script on a word 'Camera'. It opens up a dialog asking for the keyword. But clicking on search or even next causes the script to hang at "parsing data. Something wrong?


- Amarvir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116095/#review51346
-----------------------------------------------------------


On Feb. 28, 2014, 5:17 p.m., Maximilian Reiner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116095/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 5:17 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Parley Google images plugin fails loading images with in-built screen scraper.
> Simple RESTful image search with Google's API seems to be more preferable to do this. 
> 
> 
> Diffs
> -----
> 
>   google_images.orig 5317ba6 
> 
> Diff: https://git.reviewboard.kde.org/r/116095/diff/
> 
> 
> Testing
> -------
> 
> Loading images with Google JSON AJAX API succeeded. 
> 
> 
> Thanks,
> 
> Maximilian Reiner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140228/a019a373/attachment.html>