Review Request 116092: [Parley][Patch] Feature #228634: Adds a legend for the statistics.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116092/#review50962
-----------------------------------------------------------

Ship it!


Looks good.  Fix the translation issue and you can commit.


src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/116092/#comment35768>

    i18n() for the strings.
    Note that you may want to give some context to the translators, so perhaps i18nc() is better here.


- Inge Wallin


On Feb. 26, 2014, 5:14 p.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116092/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 5:14 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Implements the wish #228634. Adds a legend in the header of the lesson statistics.
> 
> 
> Diffs
> -----
> 
>   src/statistics/lessonstatistics.cpp 16ef46c 
> 
> Diff: https://git.reviewboard.kde.org/r/116092/diff/
> 
> 
> Testing
> -------
> 
> Tested on 1920x1080 screen.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140226/917c32e6/attachment.html>