Review Request 116041: Allow images to be used instead of words in flashcard practice

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116041/#review50783
-----------------------------------------------------------


I would prefer to have a self-contained patch to go in that also respects the configuration settings.


src/configure-practice/advancedpracticeoptions.ui
<https://git.reviewboard.kde.org/r/116041/#comment35635>

    The "Check this" can be removed IMO as it is also not used for other checkbox descriptions, better something like:
    "Enable picture only practise mode."



src/configure-practice/advancedpracticeoptions.ui
<https://git.reviewboard.kde.org/r/116041/#comment35636>

    isn't it "Use image instead of word"?



src/practice/abstractbackendmode.cpp
<https://git.reviewboard.kde.org/r/116041/#comment35638>

    what is the purpose of this compile switch?



src/practice/abstractbackendmode.cpp
<https://git.reviewboard.kde.org/r/116041/#comment35637>

    tailing whitespace



src/practice/entryfilter.cpp
<https://git.reviewboard.kde.org/r/116041/#comment35640>

    that is a one-line call to the settings singleton and should go into this patch



src/practice/flashcardmodewidget.cpp
<https://git.reviewboard.kde.org/r/116041/#comment35641>

    indentation is wrong: 3 instead of 4 spaces



src/practice/flashcardmodewidget.cpp
<https://git.reviewboard.kde.org/r/116041/#comment35642>

    indentation is wrong


- Andreas Cord-Landwehr


On Feb. 25, 2014, 7:34 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116041/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 7:34 a.m.)
> 
> 
> Review request for KDE Edu and Amarvir Singh.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This patch implements wish 281120 - wish: ability to use only image for a "language"
> 
> The point of it is to be able to use the flashcard implementation in Parley to train other things than languages.  Naval buoys are mentioned in the wish but there are many things that could be learned using images: flags, geography, presidents, etc.
> 
> Note: There is a configuration checkbox to allow this, but that is not yet connected to any code. The reason for that is that there are several other checkboxes that are also not connected to any code.  This has to be taken care of, of course, but we need to get this patch in today before the string freeze.
> 
> Aside from the configuration the code works as expected even though we should probably increase the image size in the flashcard.
> 
> 
> Diffs
> -----
> 
>   TODO 6a75001 
>   src/configure-practice/advancedpracticeoptions.ui 87a2a6a 
>   src/practice/abstractbackendmode.cpp 25a97cb 
>   src/practice/entryfilter.cpp a3afe84 
>   src/practice/flashcardmodewidget.cpp e578153 
> 
> Diff: https://git.reviewboard.kde.org/r/116041/diff/
> 
> 
> Testing
> -------
> 
> Checked using a test file that I created.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140225/cb90f81e/attachment-0001.html>