Review Request 115900: Add options to delete grades from lesson subtrees.
Inge Wallin
inge at lysator.liu.se
Tue Feb 25 07:51:11 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115900/#review50784
-----------------------------------------------------------
Ship it!
Ok, the text is fine but remove capitalization before commit, except for the shortcut markers (like &Grades).
src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115900/#comment35639>
The text is good but the capitalization of Sub-Lessons is not. There is no reason to capitalize nouns in non-German text. :)
The same is true for the strings below.
- Inge Wallin
On Feb. 22, 2014, 3:36 p.m., Andreas Cord-Landwehr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115900/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 3:36 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Bugs: 312995
> http://bugs.kde.org/show_bug.cgi?id=312995
>
>
> Repository: parley
>
>
> Description
> -------
>
> Add options to delete grades from lesson subtrees.
>
> Add context menu options to remove all grades from a selected lesson or alternatively from it and all sub-lessons of the selected lesson.
> Also clarify the Remove Grades option in the main menu.
>
>
> Diffs
> -----
>
> src/editor/editorui.rc c8a51d3
> src/statistics/lessonstatistics.h 022b411
> src/statistics/lessonstatistics.cpp e9bb64f
> src/vocabulary/lessonview.h ae29e5a
> src/vocabulary/lessonview.cpp 35ae863
>
> Diff: https://git.reviewboard.kde.org/r/115900/diff/
>
>
> Testing
> -------
>
> compiled and tested
>
>
> Thanks,
>
> Andreas Cord-Landwehr
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140225/52d5a8ec/attachment.html>
More information about the kde-edu
mailing list