Review Request 115900: Add options to delete grades from lesson subtrees.

Amarvir Singh amarvir.ammu.93 at gmail.com
Sat Feb 22 11:53:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115900/#review50512
-----------------------------------------------------------


Tested it and it works fine, as intended. For some ease, I have pointed out the general locations where you'll find the 'Childs'->'Children' issue, as Inge pointed out. Be sure to check the adjoining lines too. :) If these changes are made, we can ship it.


src/statistics/lessonstatistics.h
<https://git.reviewboard.kde.org/r/115900/#comment35546>

    Use 'Children' everywhere :)



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115900/#comment35547>

    Children



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115900/#comment35548>

    ...



src/vocabulary/lessonview.h
<https://git.reviewboard.kde.org/r/115900/#comment35554>

    ...



src/vocabulary/lessonview.h
<https://git.reviewboard.kde.org/r/115900/#comment35549>

    ...



src/vocabulary/lessonview.cpp
<https://git.reviewboard.kde.org/r/115900/#comment35550>

    ...



src/vocabulary/lessonview.cpp
<https://git.reviewboard.kde.org/r/115900/#comment35551>

    ...



src/vocabulary/lessonview.cpp
<https://git.reviewboard.kde.org/r/115900/#comment35552>

    ...



src/vocabulary/lessonview.cpp
<https://git.reviewboard.kde.org/r/115900/#comment35553>

    ...


- Amarvir Singh


On Feb. 20, 2014, 2:31 a.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115900/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 2:31 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Add options to delete grades from lesson subtrees.
> 
> Add context menu options to remove all grades from a selected lesson or alternatively from it and all sub-lessons of the selected lesson.
> Also clarify the Remove Grades option in the main menu.
> 
> 
> Diffs
> -----
> 
>   src/editor/editorui.rc c8a51d3 
>   src/parleyactions.cpp beaa8bd 
>   src/statistics/lessonstatistics.h 022b411 
>   src/statistics/lessonstatistics.cpp e9bb64f 
>   src/vocabulary/lessonview.h ae29e5a 
>   src/vocabulary/lessonview.cpp 35ae863 
> 
> Diff: https://git.reviewboard.kde.org/r/115900/diff/
> 
> 
> Testing
> -------
> 
> compiled and tested
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140222/baf08cfc/attachment-0001.html>


More information about the kde-edu mailing list