Review Request 115900: Add options to delete grades from lesson subtrees.

Inge Wallin inge at lysator.liu.se
Wed Feb 19 21:34:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115900/#review50282
-----------------------------------------------------------


I need to test this too.  In the mean time, you have some code comments here.


src/editor/editorui.rc
<https://git.reviewboard.kde.org/r/115900/#comment35389>

    The plural is "children". :)



src/parleyactions.cpp
<https://git.reviewboard.kde.org/r/115900/#comment35388>

    I am not sure this is much of an improvement.  "active vocabulary collection" is not defined anywhere as far as I know. And the general RR text mentions "selected lessons".  is this not the same here?


- Inge Wallin


On Feb. 19, 2014, 9:01 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115900/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 9:01 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Add options to delete grades from lesson subtrees.
> 
> Add context menu options to remove all grades from a selected lesson or alternatively from it and all sub-lessons of the selected lesson.
> Also clarify the Remove Grades option in the main menu.
> 
> 
> Diffs
> -----
> 
>   src/editor/editorui.rc c8a51d3 
>   src/parleyactions.cpp beaa8bd 
>   src/statistics/lessonstatistics.h 022b411 
>   src/statistics/lessonstatistics.cpp e9bb64f 
>   src/vocabulary/lessonview.h ae29e5a 
>   src/vocabulary/lessonview.cpp 35ae863 
> 
> Diff: https://git.reviewboard.kde.org/r/115900/diff/
> 
> 
> Testing
> -------
> 
> compiled and tested
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140219/314dfae2/attachment.html>


More information about the kde-edu mailing list