Review Request 115892: Implement sound support for flashcard practice mode

[Andreas Cord-Landwehr]

> On Feb. 19, 2014, 7:25 p.m., Andreas Cord-Landwehr wrote:
> > Ship It!

didn't test the changes, but they look straight forward.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115892/#review50275
-----------------------------------------------------------


On Feb. 19, 2014, 10:51 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115892/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 10:51 a.m.)
> 
> 
> Review request for KDE Edu and Amarvir Singh.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This patch implements sounds support for flashcards in Parley.
> 
> I started to play around a bit and see how it was done in the written words practice mode and then I just copied relevant parts of the code and the ui file.  And behold!  It actually works.
> 
> There seems to be a bug in there that makes the sound button for the solution to sometimes appear and sometimes not, but I think that is a bug in the engine rather than in the flashcard class.  There is also a bug that makes the sound button itself stay in the "playing" state much longer than is warranted by the size of the sound file. But that is also not in the new code (it's also present in the previous practice modes that supported sound).
> 
> 
> Diffs
> -----
> 
>   TODO b264925 
>   src/practice/flashcardmodewidget.cpp 9d7ee9f 
>   src/practice/practice_widget_flashcard.ui c43a528 
> 
> Diff: https://git.reviewboard.kde.org/r/115892/diff/
> 
> 
> Testing
> -------
> 
> Created a test file with some sounds in it and practiced that N times.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140219/604c35c4/attachment.html>