Review Request 115758: Add sound to kgeography

[Albert Astals Cid]

> On Feb. 17, 2014, 10:49 p.m., Albert Astals Cid wrote:
> > src/kgeography.kcfg, line 44
> > <https://git.reviewboard.kde.org/r/115758/diff/4/?file=244622#file244622line44>
> >
> >     Do you think it makes sense this to be enabled by default? I am not sure
> 
> Jaime Torres Amate wrote:
>     I'm not sure also, but the bug report say it should be enabled by default. So I'll change it.

Well, if you make it enabled by default you should make it so that there is some file selected by default, otherwise it's weird.


> On Feb. 17, 2014, 10:49 p.m., Albert Astals Cid wrote:
> > CMakeLists.txt, line 14
> > <https://git.reviewboard.kde.org/r/115758/diff/4/?file=244606#file244606line14>
> >
> >     There's two sounds folders? One here and one in src? Maybe you can attach to the bug the files they contain so i can actually test this?
> 
> Jaime Torres Amate wrote:
>     I'm not sure if it should have its own sound files. The open file dialog now goes to KDE default sound files folder.
>     Should it point to its own sound directory (If I find the KDE_Glass_Break.ogg)?
>     But, yes, in any case, one (or zero) sound directory is enough.
>     By the way, I do not have the KDE_Glass_Break.ogg file in KDE4 sources (including kdeartwork). Will search at home. Was it a KDE 3 file?

Well, if it doesn't have it's own sound files how are we going to make it work? Should every user in the world chose it's sounds? Doesn't seem very usable. I'm not sure we should even let them configure it, but ok, let's give them the option to configure, but not having a default selected sound makes it harder to everyone for no reason.

No idea what happened to KDE_Glass_Break.ogg


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115758/#review50112
-----------------------------------------------------------


On Feb. 17, 2014, 7:47 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115758/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 7:47 p.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 132702
>     http://bugs.kde.org/show_bug.cgi?id=132702
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> The code to choose the sound file is borrowed from kalarm.
> Add phonon to play sounds (can not be easier).
> Add the configuration to select the sound files.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e7a6d9c 
>   src/CMakeLists.txt 9e49f0d 
>   src/askwidget.h 32421b0 
>   src/askwidget.cpp 7f9e3cc 
>   src/boxasker.h 507099f 
>   src/boxasker.cpp f0a5b60 
>   src/capitaldivisionasker.h 744c43c 
>   src/capitaldivisionasker.cpp 495eb26 
>   src/divisioncapitalasker.h 0246482 
>   src/divisioncapitalasker.cpp 625379b 
>   src/divisionflagasker.h ffee8c2 
>   src/divisionflagasker.cpp 361c973 
>   src/flagdivisionasker.h 623a249 
>   src/flagdivisionasker.cpp 34f7711 
>   src/kgeography.h 4506bd0 
>   src/kgeography.cpp e5e5305 
>   src/kgeography.kcfg 14f5d4f 
>   src/kgeographyoptions.ui 109b077 
>   src/mapasker.h 4e89fe5 
>   src/mapasker.cpp 22e0c24 
>   src/placeasker.h 7d27178 
>   src/placeasker.cpp d65e030 
> 
> Diff: https://git.reviewboard.kde.org/r/115758/diff/
> 
> 
> Testing
> -------
> 
> It only make sounds when selected in the configuration, and the sound file exists.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140218/040b4cf0/attachment.html>