Review Request 115758: Add sound to kgeography

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115758/
-----------------------------------------------------------

(Updated Feb. 17, 2014, 7:47 p.m.)


Review request for KDE Edu and Albert Astals Cid.


Changes
-------

Why do we need kio?

Because, otherwise, I get the following link errors.
/g/kdegit/kdeedu/kgeography/src/kgeography.cpp:239: undefined reference to `KFileDialog::KFileDialog(KUrl const&, QString const&, QWidget*, QWidget*)'
/g/kdegit/kdeedu/kgeography/src/kgeography.cpp:240: undefined reference to `KFileDialog::setOperationMode(KFileDialog::OperationMode)'
/g/kdegit/kdeedu/kgeography/src/kgeography.cpp:241: undefined reference to `KFileDialog::setMode(QFlags<KFile::Mode>)'
/g/kdegit/kdeedu/kgeography/src/kgeography.cpp:244: undefined reference to `KFileDialog::setSelection(QString const&)'
/g/kdegit/kdeedu/kgeography/src/kgeography.cpp:247: undefined reference to `KFileDialog::selectedUrl() const'

Why do we need to have the configure dialog created all the time now?
Changed to pointer.

Maybe make this an Url so you don't need the casts in the askWidget::playSound function?
I've tried, but the Url settings are not saved/read. :-(

Removed the unneeded includes.


Bugs: 132702
    http://bugs.kde.org/show_bug.cgi?id=132702


Repository: kgeography


Description
-------

The code to choose the sound file is borrowed from kalarm.
Add phonon to play sounds (can not be easier).
Add the configuration to select the sound files.


Diffs (updated)
-----

  CMakeLists.txt e7a6d9c 
  src/CMakeLists.txt 9e49f0d 
  src/askwidget.h 32421b0 
  src/askwidget.cpp 7f9e3cc 
  src/boxasker.h 507099f 
  src/boxasker.cpp f0a5b60 
  src/capitaldivisionasker.h 744c43c 
  src/capitaldivisionasker.cpp 495eb26 
  src/divisioncapitalasker.h 0246482 
  src/divisioncapitalasker.cpp 625379b 
  src/divisionflagasker.h ffee8c2 
  src/divisionflagasker.cpp 361c973 
  src/flagdivisionasker.h 623a249 
  src/flagdivisionasker.cpp 34f7711 
  src/kgeography.h 4506bd0 
  src/kgeography.cpp e5e5305 
  src/kgeography.kcfg 14f5d4f 
  src/kgeographyoptions.ui 109b077 
  src/mapasker.h 4e89fe5 
  src/mapasker.cpp 22e0c24 
  src/placeasker.h 7d27178 
  src/placeasker.cpp d65e030 

Diff: https://git.reviewboard.kde.org/r/115758/diff/


Testing
-------

It only make sounds when selected in the configuration, and the sound file exists.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140217/89177403/attachment-0001.html>