Review Request 115754: [Patch][parley]Fixes the implementation of grades and boxes in practice mode and the working of '3 consecutive right answers' mode

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115754/#review49899
-----------------------------------------------------------


Overall patch looks good, only some minor issues.
* some of the comments can be made more compact (especially, the do not need to be complete sentences)
* maybe with another patch, several methods can be made "const", here only marking the method newly introduced by this patch to make patch minimal


src/practice/practicestatemachine.cpp
<https://git.reviewboard.kde.org/r/115754/#comment35066>

    can be phrased shorter:
    
    normal mode: check if current word was answered wrong -> if yes, mark next grade as achievable
    alternatite mode (3 consecutive answers): check if word was answered wrong and two consecutive times correct -> if yes, mark next grade as achievable



src/practice/practicestatemachine.cpp
<https://git.reviewboard.kde.org/r/115754/#comment35067>

    break line at "||", line is too long



src/practice/testentry.cpp
<https://git.reviewboard.kde.org/r/115754/#comment35064>

    better phrased (simpler sentence):
    "increase grade, if answered correctly and not answered wrong in current test



src/practice/testentry.cpp
<https://git.reviewboard.kde.org/r/115754/#comment35063>

    make method const


- Andreas Cord-Landwehr


On Feb. 15, 2014, 9:52 a.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115754/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2014, 9:52 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 331149
>     http://bugs.kde.org/show_bug.cgi?id=331149
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This fixes three issues with the implementation of grades and boxes, which become obvious when using the alternative learning mode (3 consecutive right answers).
> These issues are:
> 
>       1. In alternative learning mode, the next grade box lights up, even though the question hasn't been answered correctly thrice consecutively, only to return back
>          to the previous grade when the question is asked again.
> 
>       2. For a new word, that hasn't been learned yet, if the user answers it correctly the first time, ie. he/she knew the word already, the grade should increase from 0 to 2.
>          (0 to 1 for having learnt the word, and 1 to 2 for correctly answering it).
>          This would signify that the user knew the word already. But, even though the practice mode shows this increase in grades through the boxes, it doesn't actually
>          increase the grade twice. The next time this word is seen in practice, it is actually at grade 1. This is actually an effect of issue 3.
> 
>       3. Parley doesn't increase the grade from 0 to 1 (new to learned) just because it has been seen once, in case the user answered it correctly.
>          The increase seen is actually due to the "answered correctly" part and not the "this word has been learned" part.
>          The effect of this issue can been clearly seen in alternative mode. In case the word is answered once correctly, the next occurrence of the same word doesn't have the
>          grade 1 box lit up. And starting a new session without answering thrice or answering wrong, results in the word being marked as unseen.
> 
> This patch fixes these bugs, so that even the alternative learning mode works correctly.
> 
> Fixes BUG: #331149
> 
> 
> Diffs
> -----
> 
>   src/practice/testentry.h 5519197 
>   src/practice/testentry.cpp df9716d 
>   src/practice/practicestatemachine.cpp 016370a 
> 
> Diff: https://git.reviewboard.kde.org/r/115754/diff/
> 
> 
> Testing
> -------
> 
> Tested, and the patch works successfully.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140216/0f158d14/attachment.html>