Review Request 115604: Fix memory corruption on quit by canceling the active construct mode

Jacob Welsh jwelsh at eemta.org
Thu Feb 13 21:55:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115604/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 9:55 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Bugs: 173384
    http://bugs.kde.org/show_bug.cgi?id=173384


Repository: kig


Description
-------

Modification of three year old patch from Christoph Feck. See bug for details.


Diffs
-----

  kig/kig.cpp b3f5c8b 
  kig/kig_part.h 7a9b151 
  kig/kig_part.cpp 17eb0f2 
  modes/mode.cc cb5b932 

Diff: https://git.reviewboard.kde.org/r/115604/diff/


Testing
-------

Attempted to quit the application while in a construction mode, both though close button and Quit action. With the patch, it quits without crashing. Also tested with unsaved changes; the save dialog continues to work as expected.


Thanks,

Jacob Welsh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140213/34f6f7d2/attachment.html>


More information about the kde-edu mailing list