Review Request 115549: Indentation changes according to Kdelibs coding style

Amarvir Singh amarvir.ammu.93 at gmail.com
Wed Feb 12 16:54:42 UTC 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115549/
-----------------------------------------------------------

(Updated Feb. 12, 2014, 4:54 p.m.)


Review request for KDE Edu.


Changes
-------

Fixed the issues mentioned. Also made the changes based on the latest master version, so no need of the parent diff.


Repository: parley


Description
-------

Indentation changes and whitespace changes according to Kdelibs coding style. Mainly made using astyle script. Some XML indentation is done too.

Based on the parent diff, that has been merged.


Diffs (updated)
-----

  src/settings/kgametheme/kgametheme.h 5e06a70 
  src/settings/kgametheme/kgametheme.cpp f9a374b 
  src/settings/kgametheme/kgamethemeselector.h a95cc89 
  src/settings/kgametheme/kgamethemeselector.cpp d89a1fe 
  src/settings/languageproperties.h 2f5ac49 
  src/settings/languageproperties.cpp 15a5894 
  src/settings/languagepropertiespage.h 5c19792 
  src/settings/languagepropertiespage.cpp d877f99 
  src/settings/parleyprefs.cpp 7f4bf47 
  src/settings/viewoptions.cpp 99b15d7 
  src/statistics/conjugationoptions.h 2ebb0c3 
  src/statistics/conjugationoptions.cpp a2b0f35 
  src/statistics/lessonstatistics.h 7722feb 
  src/statistics/lessonstatistics.cpp 41d33f9 
  src/statistics/statisticsmainwindow.h 3ad22ac 
  src/statistics/statisticsmainwindow.cpp e5a63b3 
  src/statistics/statisticsmodel.cpp e3791ae 
  src/vocabulary/basiccontainermodel.h 98999b5 
  src/vocabulary/basiccontainermodel.cpp a14a857 
  src/vocabulary/containermimedata.h ef71021 
  src/vocabulary/containermodel.h 4cd5ab3 
  src/vocabulary/containermodel.cpp bf91b73 
  src/vocabulary/containerview.h 92e5810 
  src/vocabulary/leitnerview.cpp b87d0a4 
  src/vocabulary/lessonmodel.h 942dc05 
  src/vocabulary/lessonmodel.cpp 937d6d4 
  src/vocabulary/lessonview.h 7ad607f 
  src/vocabulary/lessonview.cpp 6c6b679 
  src/vocabulary/vocabularycolumnsdialog.h 10955b5 
  src/vocabulary/vocabularycolumnsdialog.cpp 524111e 
  src/vocabulary/vocabularydelegate.h 6bde4db 
  src/vocabulary/vocabularydelegate.cpp 412814a 
  src/vocabulary/vocabularyfilter.h 0a8b161 
  src/vocabulary/vocabularyfilter.cpp e03f1d7 
  src/vocabulary/vocabularyheaderview.h 3cdb550 
  src/vocabulary/vocabularyheaderview.cpp 0f9e39e 
  src/vocabulary/vocabularymimedata.h 708da60 
  src/vocabulary/vocabularymimedata.cpp b960587 
  src/vocabulary/vocabularymodel.h f62187e 
  src/vocabulary/vocabularymodel.cpp d2a76b2 
  src/vocabulary/vocabularyview.h 67edc4e 
  src/vocabulary/vocabularyview.cpp 434f50e 
  src/vocabulary/wordtypemodel.h 3923492 
  src/vocabulary/wordtypemodel.cpp d850c57 
  src/vocabulary/wordtypeview.h 95b434f 
  src/vocabulary/wordtypeview.cpp eef46c5 
  src/welcomescreen/buttondelegate.h b3dd213 
  src/welcomescreen/buttondelegate.cpp 0226d27 
  src/welcomescreen/welcomescreen.h aff6179 
  src/welcomescreen/welcomescreen.cpp 32ffb6f 
  src/practice/practicestatemachine.h c35a57a 
  src/practice/practicestatemachine.cpp 03da990 
  src/practice/practicesummarycomponent.h 7e33965 
  src/practice/practicesummarycomponent.cpp 562fc92 
  src/practice/statustoggle.h 35fe3b7 
  src/practice/statustoggle.cpp 7265a83 
  src/practice/statustogglebutton.h f9c5aeb 
  src/practice/statustogglebutton.cpp 7411bf5 
  src/practice/summarybarwidget.h 3b3d5ed 
  src/practice/summarybarwidget.cpp 1558028 
  src/practice/testentry.h 1db0754 
  src/practice/testentry.cpp e047b9e 
  src/practice/testentrymanager.h 5b63165 
  src/practice/testentrymanager.cpp a6a1eac 
  src/practice/themedbackgroundrenderer.h d274dc2 
  src/practice/themedbackgroundrenderer.cpp a817248 
  src/practice/writtenbackendmode.h 251fc02 
  src/practice/writtenbackendmode.cpp b23c38f 
  src/practice/writtenpracticevalidator.h 3ae63ac 
  src/practice/writtenpracticevalidator.cpp 4fdf59d 
  src/practice/writtenpracticewidget.h 7573d5b 
  src/practice/writtenpracticewidget.cpp 05e2a16 
  src/scripts/script.h d7c3133 
  src/scripts/script.cpp 840d60d 
  src/scripts/scriptdialog.h 2296eec 
  src/scripts/scriptdialog.cpp ec2a779 
  src/scripts/scripting/container.h 1256dbd 
  src/scripts/scripting/container.cpp df7fc09 
  src/scripts/scripting/document.h 1924824 
  src/scripts/scripting/document.cpp 58f6978 
  src/scripts/scripting/expression.h d7af07e 
  src/scripts/scripting/expression.cpp 5823a76 
  src/scripts/scripting/identifier.h ca73083 
  src/scripts/scripting/identifier.cpp 639f206 
  src/scripts/scripting/lesson.h 8860e82 
  src/scripts/scripting/lesson.cpp 5c8ca54 
  src/scripts/scripting/parley.h cf0230d 
  src/scripts/scripting/parley.cpp 7abdf52 
  src/scripts/scripting/text.h 84daf9f 
  src/scripts/scripting/text.cpp b331601 
  src/scripts/scripting/translation.h 1c6cd8f 
  src/scripts/scripting/translation.cpp 5b8dd42 
  src/scripts/scriptmanager.h 1a390e0 
  src/scripts/scriptmanager.cpp 0e8926a 
  src/scripts/translator.h 678bb45 
  src/scripts/translator.cpp 6d461d2 
  src/settings/documentproperties.cpp 7d0046e 
  src/settings/generaloptions.cpp 2168da8 
  src/practice/imagecache.cpp 651ba1a 
  src/practice/imagewidget.h 561be8f 
  src/practice/imagewidget.cpp 63b42a4 
  src/practice/latexrenderer.h 37449b8 
  src/practice/latexrenderer.cpp 855f956 
  src/practice/mixedlettersmodewidget.h 8d49285 
  src/practice/mixedlettersmodewidget.cpp ff1f190 
  src/practice/multiplechoicebackendmode.h c107d0f 
  src/practice/multiplechoicebackendmode.cpp 9fa6aae 
  src/practice/multiplechoicedata.h 11b36d9 
  src/practice/multiplechoicemodewidget.h b97c1ae 
  src/practice/multiplechoicemodewidget.cpp a26eafc 
  src/practice/practicemainwindow.h 2734541 
  src/practice/practicemainwindow.cpp 9f23ae9 
  src/practice/practiceoptions.h 62eb082 
  src/practice/practiceoptions.cpp 66cd37d 
  src/editor/multiplechoicewidget.cpp 7b8c7e9 
  src/editor/summarywordwidget.h 0811667 
  src/editor/summarywordwidget.cpp 008fcfd 
  src/editor/synonymwidget.h eee66fe 
  src/editor/synonymwidget.cpp 4090aca 
  src/export/exportdialog.h 6eec6a1 
  src/export/exportdialog.cpp f7dc2ce 
  src/main.cpp 3c578e6 
  src/modeltest/modeltest.h 18b7081 
  src/modeltest/modeltest.cpp b360f67 
  src/parleyactions.h 880ddd4 
  src/parleyactions.cpp 8f239fb 
  src/parleydocument.h 05e8463 
  src/parleydocument.cpp 606e9e6 
  src/parleymainwindow.h 554ce25 
  src/parleymainwindow.cpp cd26f4f 
  src/practice/abstractbackendmode.h 55d784b 
  src/practice/abstractbackendmode.cpp 6dba422 
  src/practice/abstractfrontend.h 5cff651 
  src/practice/abstractwidget.h 3156b17 
  src/practice/answervalidatorold.h cdfc182 
  src/practice/answervalidatorold.cpp 1e0dff9 
  src/practice/audiobutton.h abebaf4 
  src/practice/audiobutton.cpp 2aae366 
  src/practice/boxeswidget.h 272b7ba 
  src/practice/boxeswidget.cpp 8f4b2b2 
  src/practice/comparisonbackendmode.h db3d52b 
  src/practice/comparisonbackendmode.cpp 2e539f1 
  src/practice/comparisonmodewidget.h 7307d9c 
  src/practice/conjugationbackendmode.h 023982f 
  src/practice/conjugationbackendmode.cpp 78d4f6c 
  src/practice/conjugationdata.h d2298be 
  src/practice/conjugationmodewidget.h d6e63ee 
  src/practice/conjugationmodewidget.cpp 4491304 
  src/practice/entryfilter.h 17640d8 
  src/practice/entryfilter.cpp 9cde17d 
  src/practice/examplesentencebackendmode.h d9472a3 
  src/practice/examplesentencebackendmode.cpp 1a46ba9 
  src/practice/flashcardbackendmode.h b47c1b3 
  src/practice/flashcardbackendmode.cpp f0e5bda 
  src/practice/flashcardmodewidget.h ea336bb 
  src/practice/flashcardmodewidget.cpp a421379 
  src/practice/genderbackendmode.h a54c0bf 
  src/practice/genderbackendmode.cpp 7c9b42b 
  src/practice/guifrontend.h 3e76a98 
  src/practice/guifrontend.cpp 6c948be 
  src/practice/imagecache.h a4a9719 
  plasmoid/engine/parley_engine.h 5db00b5 
  plasmoid/engine/parley_engine.cpp fd6947e 
  plasmoid/parley_plasma.h 2c47ccd 
  plasmoid/parley_plasma.cpp e9d3a53 
  scripts_test/main.cpp e036dc9 
  scripts_test/scripts.h 5ceed98 
  scripts_test/scripts.cpp 1ec2dff 
  scripts_test/translationscript.h fb02db9 
  scripts_test/translationscript.cpp b4fe650 
  src/configure-practice/blockoptions.cpp a6b9640 
  src/configure-practice/configurepracticedialog.cpp 36aa8ec 
  src/editor/FromToEntryPage.cpp 4b6b474 
  src/editor/audiowidget.h 4f2389b 
  src/editor/audiowidget.cpp 4c80a81 
  src/editor/browserwidget.h e36c9f0 
  src/editor/browserwidget.cpp 506e71d 
  src/editor/comparisonwidget.h a819e48 
  src/editor/comparisonwidget.cpp 7589bac 
  src/editor/conjugationwidget.h fbb0751 
  src/editor/conjugationwidget.cpp 76f20e1 
  src/editor/declensionwidget.h d0931bf 
  src/editor/declensionwidget.cpp 5c03f3e 
  src/editor/editor.h 2497938 
  src/editor/editor.cpp f3787a3 
  src/editor/imagechooserwidget.h b62ebb6 
  src/editor/imagechooserwidget.cpp a4e3f86 
  src/editor/inflectionwidget.h bde55bb 
  src/editor/inflectionwidget.cpp 0f643a0 
  src/editor/latexwidget.h e281ca5 
  src/editor/latexwidget.cpp 46f81d6 
  src/editor/multiplechoicewidget.h 15c87b2 

Diff: https://git.reviewboard.kde.org/r/115549/diff/


Testing
-------

Tested. No functional changes at all.


Thanks,

Amarvir Singh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140212/fcf7f25a/attachment-0001.html>

More information about the kde-edu mailing list