Review Request 115439: Open ExpressionWritter API: AbstractExpressionWriter

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115439/#review49437
-----------------------------------------------------------



analitza/analitzautils.cpp
<https://git.reviewboard.kde.org/r/115439/#comment34882>

    If you're going to use the switch statement then you're not following the Visitor pattern anymore.
    
    You don't even need the accept method if you're ending up casting anyway.


- Aleix Pol Gonzalez


On Feb. 10, 2014, 5:27 a.m., Percy Camilo Triveño Aucahuasi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115439/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 5:27 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> Currently ExpressionWriter allows a great flexibility to visit each node (by type) of the parser's tree, but it returns only QString as result.
> 
> I propose open this API by this generic interface: AbstractExpressionWriter. This interface can be used by any client to visit the tree and, in addition, the client can choose the type of the results for each visit.
> 
> This patch adds AbstractExpressionWriter, ExpressionWriter, List, CustomObject, Matrix, Apply and Container as public API (headers will be installed)
> 
> 
> Diffs
> -----
> 
>   analitza/CMakeLists.txt af270b6 
>   analitza/abstractexpressionwriter.h PRE-CREATION 
>   analitza/abstractexpressionwriter.cpp PRE-CREATION 
>   analitza/analitzautils.h 88b4bf8 
>   analitza/analitzautils.cpp c38eeaa 
>   analitza/apply.h 84b09f5 
>   analitza/apply.cpp e787372 
>   analitza/container.h f0deec6 
>   analitza/container.cpp aabd780 
>   analitza/expressiontypechecker.cpp 8616127 
>   analitza/expressionwriter.h ea9c92d 
>   analitza/htmlexpressionwriter.cpp cf7d4a0 
>   analitza/list.h 9719f9e 
>   analitza/list.cpp fd1e411 
>   analitza/mathmlexpressionwriter.cpp b70a1ca 
>   analitza/mathmlpresentationexpressionwriter.cpp 3efc35b 
>   analitza/matrix.h 69c109d 
>   analitza/matrix.cpp 6714ac8 
>   analitza/object.h aafd114 
>   analitza/operator.h 0e61b21 
>   analitza/operator.cpp a2d8501 
>   analitza/stringexpressionwriter.cpp 90594e8 
>   analitza/value.h 89bc2ef 
>   analitza/value.cpp 7d4e49a 
>   analitza/variable.h 2f8514c 
>   analitza/variable.cpp b98365e 
>   analitza/vector.h 338bf81 
>   analitza/vector.cpp d7b5836 
> 
> Diff: https://git.reviewboard.kde.org/r/115439/diff/
> 
> 
> Testing
> -------
> 
> build & install ok, also each class has the ANALITZA_EXPORT macro.
> 
> 
> Thanks,
> 
> Percy Camilo Triveño Aucahuasi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140210/cf32e274/attachment.html>