Review Request 115449: [PATCH] Removes gradient in statistics and makes it more intuitive. Fixes BUG:#266368

[Amarvir Singh]

> On Feb. 10, 2014, 8:45 a.m., Frederik Gladhorn wrote:
> > Thanks, this patch is much easier to read :) If it looks sensible with dark color themes that I'd say put it in.
> 
> Amarvir Singh wrote:
>     Yes, checked it with dark themes. Works perfectly fine. Thanks :)

Furthermore, I don't have the rights to merge it. Could someone do that for me? :)


- Amarvir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115449/#review49421
-----------------------------------------------------------


On Feb. 8, 2014, 2:57 a.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115449/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2014, 2:57 a.m.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Bugs: 266368 and 328279
>     http://bugs.kde.org/show_bug.cgi?id=266368
>     http://bugs.kde.org/show_bug.cgi?id=328279
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This closes the mentioned bug, as it removes the gradient in learning statistics and uses solid color.
> It also makes it even more intuitive for the user, as it uses a single color for all the grades with different alpha values, increasing as grades increase. Thus darker shades mean higher grades.
> Also the default grade colors have been changed to be the same, except grade 0.
> 
> Fixes BUG:#266368
> 
> 
> Diffs
> -----
> 
>   src/settings/parley.kcfg 34bfd98 
>   src/settings/viewoptions.cpp 7b475e0 
>   src/settings/viewoptionsbase.ui a5755f0 
>   src/statistics/lessonstatistics.cpp e09cff8 
>   src/vocabulary/vocabularymodel.cpp e8c7afb 
> 
> Diff: https://git.reviewboard.kde.org/r/115449/diff/
> 
> 
> Testing
> -------
> 
> Tested the default button, and tested for all grades. Still intuitive and working.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140210/a0d1ca83/attachment.html>