Review Request 115601: [parley][PATCH] Fixes the editor dock widgets leaking out of screen and becoming inaccessible bug, and window resizing issue with multiple widgets

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115601/#review49368
-----------------------------------------------------------


Take care that the objects that are created on the heap will be deleted.


src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34860>

    memory leak: create object as "new QScrollArea(this)" to use the qobject ownership model to take care for object deletion, once the parent qobject will be deleted



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34861>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34862>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34863>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34864>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34865>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34866>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34867>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34868>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34869>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34870>

    create as "new QScrollArea(this)"



src/editor/editor.cpp
<https://git.reviewboard.kde.org/r/115601/#comment34871>

    create as "new QScrollArea(this)"


- Andreas Cord-Landwehr


On Feb. 9, 2014, 5:39 p.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115601/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2014, 5:39 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Fixes the bug that caused widgets in the editor to leak out of the bottom of the screen, if multiple widgets were selected in view, making them inaccessible.
> The bug didn't allow the screen to be resized either as the dock widgets could not be made smaller.
> This made it an annoying bug, as it didn't allow the user to simply resize the window to access the cutoff widgets. They had to be closed, and the window had to be minimized-maximized
> to restructure the dock widgets.
> 
> Steps to reproduce: 
> 1. Go to editor mode.
> 2. View->add multiple widgets (eg synonyms, antonyms, image, latex, etc.)
> 3. The widgets start leaking out even in a Full HD screen, and some, hence, become inaccessible.
> 4. Try resizing window (decreasing size from the top), doesnt work, as QDockWidgets take a defined space.
> 
> Expected Result: 
> Widgets should not be cutoff, and resizing should be possible.
> 
> This commit makes each widget scrollable so that they can be reduced in size, to allow the window to be made smaller. Also they are tabbed together, to ensure widgets don't leak out,
> even for lower resolutions, and it also ensures that they remain accessible.
> 
> 
> Diffs
> -----
> 
>   src/editor/editor.cpp f3787a3 
> 
> Diff: https://git.reviewboard.kde.org/r/115601/diff/
> 
> 
> Testing
> -------
> 
> Tested, from 1920x1080 to 800x600 resolutions. 
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140209/a909ffaa/attachment-0001.html>