Review Request 115449: [PATCH] Removes gradient in statistics and makes it more intuitive. Fixes BUG:#266368

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115449/#review49107
-----------------------------------------------------------


Some small issues I directly spotted, but did not test the patch myself (will do later today).
Else it looks good. Though I am not sure whether all the indentation fixes of the lines that do not have to be touched by your changes, should be done in this commit.


src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34689>

    I think "GradeColor" would be easier to understand than "BaseColor" when this value is used outside the kcfg file



src/settings/viewoptions.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34690>

    should not be necessary: since there is no toggle to use colors or not, the color setting should never get disabled



src/settings/viewoptionsbase.ui
<https://git.reviewboard.kde.org/r/115449/#comment34691>

    remove whitespace (if using kate/kwrite/kdevelop you can your editor to always remove trailing whitespace of edited lines/all lines)



src/settings/viewoptionsbase.ui
<https://git.reviewboard.kde.org/r/115449/#comment34692>

    I would rephrase this to "Base color for displaying grades:"



src/settings/viewoptionsbase.ui
<https://git.reviewboard.kde.org/r/115449/#comment34694>

    "Base color for displaying grades"



src/settings/viewoptionsbase.ui
<https://git.reviewboard.kde.org/r/115449/#comment34693>

    "Click here to change the base color for displaying grades."



src/vocabulary/vocabularymodel.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34696>

    correct indentation would be:
        : QAbstractTableModel(parent)
        , m_container(0)
        , m_document(0)


- Andreas Cord-Landwehr


On Feb. 5, 2014, 5:15 p.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115449/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 5:15 p.m.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Bugs: 266368 and 328279
>     http://bugs.kde.org/show_bug.cgi?id=266368
>     http://bugs.kde.org/show_bug.cgi?id=328279
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This closes the mentioned bug, as it removes the gradient in learning statistics and uses solid color.
> It also makes it even more intuitive for the user, as it uses a single color for all the grades with different alpha values, increasing as grades increase. Thus darker shades mean higher grades.
> Also the default grade colors have been changed to be the same, except grade 0.
> 
> Fixes BUG:#266368
> 
> 
> Diffs
> -----
> 
>   src/settings/parley.kcfg 34bfd98 
>   src/settings/viewoptions.cpp 7b475e0 
>   src/settings/viewoptionsbase.ui a5755f0 
>   src/statistics/lessonstatistics.cpp e09cff8 
>   src/vocabulary/vocabularymodel.cpp e8c7afb 
> 
> Diff: https://git.reviewboard.kde.org/r/115449/diff/
> 
> 
> Testing
> -------
> 
> Tested the default button, and tested for all grades. Still intuitive and working.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140206/89f86c3d/attachment.html>