Review Request 121770: A bit of cleanup. Bump version to 3.0 since the whole ui is different. Remove unused private data from khangman class. Cleanup includes a bit. Remove commented out lines of code. Add .reviewboardrc file.
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Dec 30 23:14:23 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121770/#review72805
-----------------------------------------------------------
src/qml/GamePage.qml
<https://git.reviewboard.kde.org/r/121770/#comment50702>
Now that you're cleaning up, this is a _very_ weird use of the ternary operator.
+1, all in all.
- Aleix Pol Gonzalez
On Dec. 30, 2014, 10:24 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121770/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 10:24 p.m.)
>
>
> Review request for KDE Edu and Rahul Chowdhury.
>
>
> Repository: khangman
>
>
> Description
> -------
>
> A bit of cleanup. Bump version to 3.0 since the whole ui is different. Remove unused private data from khangman class. Cleanup includes a bit. Remove commented out lines of code. Add .reviewboardrc file. renamed sound property to soundEnabled and tweaked methods for consistency.
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> src/khangman.h defb2c30fe0926c96a86f704098b90846a3809bb
> src/khangman.cpp af394b994479f40e68cc8b2304487201cf349b19
> src/main.cpp 7ea4e32abb86bf924f26fc592fcc3622acfd6c83
> src/qml/CMakeLists.txt 47d84c2caab8218395a58849489035687344f949
> src/qml/GamePage.qml 3f573ca5d6d4ffd62c4888703496fd21e7ea63b3
> src/qml/MainSettingsDialog.qml 4a41f76d44e74681b109a099d2d0a07a9094ecbe
> src/qml/UIConstants.js 263a196cf00bb7526bc1d9c7b43ab03c5e313bb3
> src/qml/main.qml 215d2fbee7cbb7ce90cf238629960e46b9963f21
> src/qml/sounds/CMakeLists.txt c3ec706a97ff32057cb7c03ef86a86cb8b96a96f
> src/version.h 617549f4add19c136b75dba754d136f1d15a2c86
>
> Diff: https://git.reviewboard.kde.org/r/121770/diff/
>
>
> Testing
> -------
>
> It builds and runs still.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141230/15d41ff7/attachment.html>
More information about the kde-edu
mailing list