Review Request 121750: Remove phonon dependency. Use QtMultimedia in qml instead for sounds. Move sound files to src/ui/sounds and install them with the other qml files.

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121750/#review72771
-----------------------------------------------------------


Sounds like a good idea to have less dependencies, especially for deployment on non-desktop devices. My only concern is that the GStreamer-1.x port of QtMultimedia is only merged into the dev-branch of QtMultimedia. And from my experience GStreamer0.10 can make/makes sometimes a lot of problems (since unmaintained since years and hence not well tested against e.g. recent pulseaudio releases).

That said, probably it is good to do the change now, since there is now a long time for testing how well it works.

Directly to your patch: there now seem to be some empty if/else clauses and also an empty function (e.g. KanagramGame::wordRevealed()). Shouldn't there be at least a comment why there is no code? Or otherwise, if not needed, shouldn't it be removed directly?

- Andreas Cord-Landwehr


On Dez. 30, 2014, 6:28 vorm., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121750/
> -----------------------------------------------------------
> 
> (Updated Dez. 30, 2014, 6:28 vorm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kanagram
> 
> 
> Description
> -------
> 
> Remove phonon dependency. Use QtMultimedia in qml instead for sounds. Move sound files to src/ui/sounds and install them with the other qml files.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5b847b98eb17cf8f846f3327324c6dae54e1ef12 
>   sounds/CMakeLists.txt eb03a902fedde15fb9ebac8d623c77001f42559b 
>   sounds/anagram-letter-press.wav 27abcd9d8d0bf644e9e78531b2b56f0b348eded3 
>   sounds/chalk.ogg  
>   sounds/chalk.wav  
>   sounds/right.ogg  
>   sounds/right.wav  
>   sounds/wrong.ogg  
>   sounds/wrong.wav  
>   src/CMakeLists.txt b8628fdf7d82068b4c4d59479662a3fc36cef3fc 
>   src/kanagramgame.h e9564cfcc6a19a3ed5e63db5340cd19a760914d5 
>   src/kanagramgame.cpp e0b60866ef49af3f28161c72982b17c6865f88ef 
>   src/ui/main.qml 38408ae66772a578a45faeb92ff9828f7c174f2a 
> 
> Diff: https://git.reviewboard.kde.org/r/121750/diff/
> 
> 
> Testing
> -------
> 
> Sounds still work as expected when Use Sounds is checked in preferences. Required some gst plugins locally, but that's an acceptable runtime requirement imo.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141230/f18707b9/attachment.html>