Review Request 121374: Cantor Python2 to Python3 backend porting for KF5

[Minh Ngo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121374/
-----------------------------------------------------------

(Updated Dec. 28, 2014, 5:03 p.m.)


Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.


Changes
-------

Fixing code review remarks


Repository: cantor


Description
-------

Have meda some fixes in cmake files to find python3 correctly...


Diffs (updated)
-----

  src/backends/python2/python2backend.cpp PRE-CREATION 
  src/backends/python3/CMakeLists.txt PRE-CREATION 
  src/backends/python3/cantor_python3.knsrc PRE-CREATION 
  src/backends/python3/python3backend.h PRE-CREATION 
  src/backends/python3/python3backend.cpp PRE-CREATION 
  src/backends/python3/python3backend.desktop PRE-CREATION 
  cmake/FindPythonLibs3.cmake PRE-CREATION 
  src/backends/CMakeLists.txt e27c84d 
  src/backends/R/cantor_r.knsrc 02f9a1e 
  src/backends/kalgebra/cantor_kalgebra.knsrc d0103eb 
  src/backends/lua/cantor_lua.knsrc 25165d0 
  src/backends/maxima/cantor_maxima.knsrc 7cccce8 
  src/backends/octave/cantor_octave.knsrc 735739a 
  src/backends/python/pythonbackend.h 553eef0 
  src/backends/python/pythonbackend.cpp 3f66f39 
  src/backends/python/pythoncompletionobject.h 1c220a5 
  src/backends/python/pythonexpression.h aa34258 
  src/backends/python/pythonexpression.cpp 883c3ea 
  src/backends/python/pythonsession.h 3e716bc 
  src/backends/python/pythonsession.cpp c252572 
  src/backends/python2/CMakeLists.txt 260c2f0 
  src/backends/python2/cantor_python2.knsrc 7ec699c 
  src/backends/python2/python2backend.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121374/diff/


Testing
-------

1)
a = 1
b = 2
print(a + b)

2)
import numpy as np
a = np.array([1, 2, 3])
print(a)


Thanks,

Minh Ngo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141228/8827fea6/attachment.html>