Review Request 121663: Refactor unit tests to make them stand-alone.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121663/#review72545
-----------------------------------------------------------


+1 makes sense to me. I like the attention to unit tests too! :D

I would appreciate a +1 from somebody else as well.

- Aleix Pol Gonzalez


On Dec. 24, 2014, 2:14 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121663/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2014, 2:14 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: step
> 
> 
> Description
> -------
> 
> Create stand-alone unit tests for unrelated tests that were
> previously grouped as a single unit test. Also change unit test
> names to default names as used for KF5.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6d1630087050dc8b663752381d5c072f7caf95c2 
>   autotests/CMakeLists.txt PRE-CREATION 
>   autotests/test_contacts.h PRE-CREATION 
>   autotests/test_metaobject.h PRE-CREATION 
>   autotests/test_worldcopy.h PRE-CREATION 
>   stepcore_tests/CMakeLists.txt ea52ffd3ec09988ec746d5d0599737b1b174ab1c 
>   stepcore_tests/contacts.cc fa0d85da3d8a497eec4a1afd69280946e6394d41 
>   stepcore_tests/maintest.h f8aa97cfb195ab7f6000b80e7ad57d9b6f1a3d3d 
>   stepcore_tests/maintest.cc 9f7963b757725904793e5322a8046e7f10d67e45 
>   stepcore_tests/metaobject.cc 2dd618c9d3ff8973ca63929ee3492668bca7fae2 
>   stepcore_tests/worldcopy.cc c015ae29939bb647a0c9fa497e413d8c4ec29692 
> 
> Diff: https://git.reviewboard.kde.org/r/121663/diff/
> 
> 
> Testing
> -------
> 
> All enabled tests pass successfully, the additional one was already commented out and has to be fixed in a later commit.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141227/5b50ffb1/attachment.html>