Review Request 121622: Eigen3 compatability mode 30, convert dot products.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121622/#review72372
-----------------------------------------------------------

Ship it!


Looks good.  However, I'm not so worried over these changes, I'm more worried about those changes that you missed.  ;) But as long as you are available for bugfixes, I'm fine with this.

- Inge Wallin


On Dec. 21, 2014, 3:44 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121622/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2014, 3:44 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: step
> 
> 
> Description
> -------
> 
> Eigen3 porting to stage 30: convert dot products to be complex conjugated to the Eigen2 dot products, i.e.: x.dot(y) -> y.dot(x).
> 
> 
> Diffs
> -----
> 
>   stepcore/joints.cc 696abf8 
>   stepcore/particle.cc 60cdadd 
>   stepcore/rigidbody.cc 6569e07 
>   stepcore/softbody.cc 62241cd 
>   stepcore/spring.cc 16c4843 
>   stepcore_tests/contacts.cc ab2ac70 
>   CMakeLists.txt 6680af2 
>   step/polygongraphics.cc 9242d88 
>   stepcore/collisionsolver.cc 9a263a8 
>   stepcore/gas.cc a731fe7 
>   stepcore/joint.cc 1d7ebfb 
> 
> Diff: https://git.reviewboard.kde.org/r/121622/diff/
> 
> 
> Testing
> -------
> 
> Run Brownian Motion example.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141221/d642e117/attachment-0001.html>