Review Request 121619: Port to Eigen3 in compatability mode

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121619/#review72366
-----------------------------------------------------------

Ship it!


Looks good so far.  It's ok to push, provided that you have tested the version that you built from these sources (I noticed there was no mention of testing).  See the small comment below.


CMakeLists.txt
<https://git.reviewboard.kde.org/r/121619/#comment50439>

    Is this still relevant?


- Inge Wallin


On Dec. 21, 2014, 2:29 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121619/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2014, 2:29 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: step
> 
> 
> Description
> -------
> 
> First patch of porting series to Eigen3. This patch does:
> * build depend on Eigen3 in Eigen2 compatability mode
> * make minimal changes to adapt to source incompatable changes
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5544b2a 
>   step/propertiesbrowser.cc 442a34f 
>   stepcore/constraintsolver.cc 10c6570 
>   stepcore/types.h 5e1e57b 
> 
> Diff: https://git.reviewboard.kde.org/r/121619/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141221/f267933d/attachment.html>