Review Request 121534: [kalzium/libscience] Port to KF5

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121534/#review72278
-----------------------------------------------------------



src/gradientwidget_impl.cpp
<https://git.reviewboard.kde.org/r/121534/#comment50409>

    Unrelated change that crept in from the other porting efforts.


- Christoph Feck


On Dec. 18, 2014, 11:02 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121534/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 11:02 p.m.)
> 
> 
> Review request for KDE Edu and Etienne Rebetez.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Not sure if anyone already looked at porting Kalzium. If not, I would like to create the frameworks branch, and push some changes I tried so far.
> 
> When I started porting the buildsystem I noticed many compile errors caused by API changes in KUnitConversion.
> 
> This review request only shows the changes inside libscience. The application does not compile yet.
> 
> I would like feedback about the (rather verbose) usage of KUnitConversion::UnitID type. Does it make sense to always "using namespace;" or maybe a typedef?
> 
> 
> Diffs
> -----
> 
>   libscience/element.cpp 762462f 
>   libscience/elementparser.h f3a8130 
>   libscience/elementparser.cpp 7c5ecaf 
>   libscience/isotopeparser.cpp 0e646c1 
>   libscience/spectrum.h 3d43d6f 
>   libscience/spectrum.cpp 9ce97a5 
>   src/calculator/concCalculator.cpp 785e77a 
>   src/calculator/gasCalculator.h 4cbcecf 
>   src/calculator/gasCalculator.cpp adef7f5 
>   src/calculator/nuclearCalculator.h f0230f8 
>   src/calculator/nuclearCalculator.cpp 488bd38 
>   src/elementdataviewer.cpp 49a2a18 
>   src/kalziumgradienttype.cpp 5130f85 
>   src/kalziumunitcombobox.h 717be9e 
>   src/kalziumunitcombobox.cpp 094ca45 
>   src/kalziumutils.h 0938b34 
>   src/kalziumutils.cpp bae9c54 
>   src/spectrumviewimpl.cpp f9c0488 
>   src/spectrumwidget.cpp 2264590 
>   src/unitsettingsdialog.h 04d5cf0 
>   src/unitsettingsdialog.cpp 4f50aca 
>   src/gradientwidget_impl.cpp 622717a 
>   src/kalziumdataobject.h 0d88856 
>   src/kalziumdataobject.cpp 3d171c6 
>   libscience/chemicaldataobject.h 55a40dc 
>   libscience/chemicaldataobject.cpp 8fac92c 
>   libscience/element.h 43979d9 
> 
> Diff: https://git.reviewboard.kde.org/r/121534/diff/
> 
> 
> Testing
> -------
> 
> libscience compiles without errors/warnings.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141218/c7387c30/attachment-0001.html>