Review Request 121566: Fix KMPlot running by changing it to a K_PLUGIN_FACTORY and fixing the name we look it up with.
Jeremy Whiting
jpwhiting at kde.org
Wed Dec 17 02:43:06 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121566/
-----------------------------------------------------------
(Updated Dec. 17, 2014, 2:43 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.
Repository: kmplot
Description
-------
Fix KMPlot running by changing it to a K_PLUGIN_FACTORY and fixing the name we look it up with.
Diffs
-----
kmplot/kmplot.cpp 9a6fe88b64a708b3ed2918779563ea79f58ec4c1
kmplot/maindlg.h 022bd02ec4b49be987950a09507402c4facec080
kmplot/maindlg.cpp ef36cf2247b5301b44a5f5b4992c407dbb0b8549
Diff: https://git.reviewboard.kde.org/r/121566/diff/
Testing
-------
It builds, runs and shows the kmplot ui where before this it doesn't.
One remaining question is the setComponentData call, Running kmplot with these changes the help->about kmplot works fine and such, so I'm not sure what that call is even for tbh.
Thanks,
Jeremy Whiting
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141217/fbe61691/attachment.html>
More information about the kde-edu
mailing list