Review Request 121534: [kalzium/libscience] Port to KF5

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121534/
-----------------------------------------------------------

(Updated Dec. 15, 2014, 9:47 p.m.)


Status
------

This change has been discarded.


Review request for KDE Edu and Etienne Rebetez.


Repository: kalzium


Description
-------

Not sure if anyone already looked at porting Kalzium. If not, I would like to create the frameworks branch, and push some changes I tried so far.

When I started porting the buildsystem I noticed many compile errors caused by API changes in KUnitConversion.

This review request only shows the changes inside libscience. The application does not compile yet.

I would like feedback about the (rather verbose) usage of KUnitConversion::UnitID type. Does it make sense to always "using namespace;" or maybe a typedef?


Diffs
-----

  libscience/chemicaldataobject.h 55a40dc 
  libscience/chemicaldataobject.cpp 8fac92c 
  libscience/element.h 43979d9 
  libscience/element.cpp 762462f 
  libscience/elementparser.h f3a8130 
  libscience/elementparser.cpp 7c5ecaf 
  libscience/isotopeparser.cpp 0e646c1 
  libscience/spectrum.h 3d43d6f 
  libscience/spectrum.cpp 9ce97a5 

Diff: https://git.reviewboard.kde.org/r/121534/diff/


Testing
-------

libscience compiles without errors/warnings.


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141215/dce4cefb/attachment-0001.html>