Review Request 121437: change in main.qml

[Jeremy Whiting]

> On Dec. 14, 2014, 11:44 a.m., Albert Astals Cid wrote:
> > Is this the same as https://git.reviewboard.kde.org/r/121438/ ? Should one of both be discarded?

Yes, he's pushed this change to his clone, this should be marked as submitted and the others marked as discarded.
Souvik, will you do that please?


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121437/#review71998
-----------------------------------------------------------


On Dec. 10, 2014, 8:25 a.m., Souvik  Das wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121437/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 8:25 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kanagram
> 
> 
> Description
> -------
> 
> Final optimised code for icon toggle in main.qml
> 
> 
> Diffs
> -----
> 
>   src/ui/icons/1player.png PRE-CREATION 
>   src/ui/icons/2player.png PRE-CREATION 
>   src/ui/main.qml 38408ae66772a578a45faeb92ff9828f7c174f2a 
>   src/kanagram.kcfg 468e316528c413b8dc42d2e9d365b6fe63c63257 
>   src/kanagramgame.h e9564cfcc6a19a3ed5e63db5340cd19a760914d5 
>   src/kanagramgame.cpp e0b60866ef49af3f28161c72982b17c6865f88ef 
> 
> Diff: https://git.reviewboard.kde.org/r/121437/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Souvik  Das
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141215/ef4c8ea8/attachment.html>