Review Request 121535: Ported main.cc to Qt5

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121535/#review72071
-----------------------------------------------------------



step/main.cc
<https://git.reviewboard.kde.org/r/121535/#comment50264>

    You're missing KLocalizedString::setApplicationDomain



step/main.cc
<https://git.reviewboard.kde.org/r/121535/#comment50265>

    remove the NOOP, you either give something translated or not, a noop is not giving you anything here


- Albert Astals Cid


On des. 15, 2014, 3:28 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121535/
> -----------------------------------------------------------
> 
> (Updated des. 15, 2014, 3:28 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: step
> 
> 
> Description
> -------
> 
> Some of the classes in main.cc were deprecated that had to be ported to the latest libraries. The new modules used are QApplication, KAboutData, QCommandLineParser, QDebug, KLocalizedString, QUrl, QDir
> 
> 
> Diffs
> -----
> 
>   step/main.cc fdb7f5f 
> 
> Diff: https://git.reviewboard.kde.org/r/121535/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141215/bc2fef07/attachment.html>