Review Request 121525: Fixed icon installation warnings

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121525/#review72014
-----------------------------------------------------------

Ship it!


Looks good.  Please just fix the minor issue I point out below and then you can push.

God job!


step/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121525/#comment50206>

    These are hardly optional and should just use add_subdirectory()


- Inge Wallin


On Dec. 14, 2014, 11:15 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121525/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2014, 11:15 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: step
> 
> 
> Description
> -------
> 
> Modified the CMakeLists files and renamed some of the png files to fix the icon installation in proper places.
> 
> 
> Diffs
> -----
> 
>   step/icons/actions/hi22-action-step_object_Spring.png 2eec6ce70d89187246390bd9ab756a88500fd3a6 
>   step/icons/actions/hi22-action-step_object_Stick.png 4ba512927c1e9c753165b0360e2bd03559dda406 
>   step/icons/actions/hi22-action-step_object_Tracer.png fb5f86bb2c3badea9afbebb11ff8d1ddd45dc30b 
>   step/icons/actions/hi22-action-step_object_WeightForce.png d1a1ce882b1be7e2c83666459d23640a702fb356 
>   step/icons/actions/hi22-actions-pointer.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Anchor.png PRE-CREATION 
>   step/icons/actions/hi22-action-step_object_Graph.png e23c6497cdac456fdae3bd0eddd2df609ec7da97 
>   step/icons/actions/hi22-action-step_object_GravitationForce.png 9fefe34f2dffef71a916e4cde9270e417a58bdf3 
>   step/icons/actions/hi22-action-step_object_LinearMotor.png cd76d7170987e0684189816ad6be66d9f6507dd9 
>   step/icons/actions/hi22-action-step_object_Meter.png a8a09d891897287df30e4b06507412f93f31c643 
>   step/icons/actions/hi22-action-step_object_Note.png 9a8d87c9d5f5950c924e6818d2db2a36d3214700 
>   step/icons/actions/hi22-action-step_object_Particle.png 1744d794052e45523b7186c74dae5dbf32952572 
>   step/icons/actions/hi22-action-step_object_Pin.png 0d7dc40b3d4fdd0e0e8171e4e0edaf25b2da3857 
>   step/icons/actions/hi22-action-step_object_Polygon.png 8b428db511568602a4759c55723f7bce4e9358bd 
>   step/icons/actions/hi22-action-step_object_Rope.png dfb05676c1231d52960320242cc2613ce4314e1f 
>   step/icons/actions/hi22-action-step_object_SoftBody.png f60aaf89dd4d7357ba6f512144af60d61941b590 
>   step/icons/actions/hi22-action-step_object_Anchor.png 4fa715743ce9b75610f32e278d87755c7f139f52 
>   step/icons/actions/hi22-action-step_object_Box.png 04c4ec58c3f8581c6e8393cbf80cde0a6753774d 
>   step/icons/actions/hi22-action-step_object_ChargedParticle.png 1744d794052e45523b7186c74dae5dbf32952572 
>   step/icons/actions/hi22-action-step_object_CircularMotor.png 01ca0fa18fa040d168b99b14c1da610f51f639c3 
>   step/icons/actions/hi22-action-step_object_Controller.png 8a2940da80f8a08ff2c18da52a733ae7e0ab6482 
>   step/icons/actions/hi22-action-step_object_CoulombForce.png 7ddd4914a880a1387741c0a6f104425ceeb1162a 
>   step/icons/actions/hi22-action-step_object_Disk.png f2e432eef03724cc9a4b96d28afbe5d08e0418e4 
>   step/icons/actions/hi22-action-step_object_Gas.png 684cd154ae83285a9af787562e7e2afc25416057 
>   step/icons/actions/hi22-action-step_object_GasParticle.png 684cd154ae83285a9af787562e7e2afc25416057 
>   CMakeLists.txt 7a39ee9 
>   step/CMakeLists.txt 554c390 
>   step/icons/CMakeLists.txt f4c5595 
>   step/icons/actions/CMakeLists.txt 439bb24 
>   step/icons/actions/hi22-action-pointer.png b658c05aba529343ea3cbd5c5ee234f755f7f737 
>   step/icons/actions/hi22-actions-step_object_Box.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_ChargedParticle.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_CircularMotor.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Controller.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_CoulombForce.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Disk.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Gas.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_GasParticle.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Graph.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_GravitationForce.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_LinearMotor.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Meter.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Note.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Particle.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Pin.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Polygon.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Rope.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_SoftBody.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Spring.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Stick.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_Tracer.png PRE-CREATION 
>   step/icons/actions/hi22-actions-step_object_WeightForce.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141214/9891157c/attachment-0001.html>