Review Request 121374: Cantor Python2 to Python3 backend porting for KF5

[Filipe Saraiva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121374/#review71926
-----------------------------------------------------------

Ship it!


Thanks for the patch, it is very nice. Unfortunately Cantor is broken now, but your code can be accept without problems. Before push it to frameworks branch, see the comments below and make the changes suggested.


src/backends/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121374/#comment50147>

    Before line 50, put the "set_package_properties" to Python 3.



src/backends/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121374/#comment50148>

    Finnish it with **endif(PYTHON3_FOUND)**



src/backends/python/pythonsession.cpp
<https://git.reviewboard.kde.org/r/121374/#comment50149>

    You can merge this two codes using *"print(dir(%1))\n"* to booth Python 2 and Python 3 code.



src/backends/python/pythonsession.cpp
<https://git.reviewboard.kde.org/r/121374/#comment50150>

    Same as previous comment.



src/backends/python/pythonsession.cpp
<https://git.reviewboard.kde.org/r/121374/#comment50151>

    Same as previous comment.


- Filipe Saraiva


On Dez. 6, 2014, 11:38 p.m., Minh Ngo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121374/
> -----------------------------------------------------------
> 
> (Updated Dez. 6, 2014, 11:38 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Have meda some fixes in cmake files to find python3 correctly...
> 
> 
> Diffs
> -----
> 
>   cmake/FindPythonLibs3.cmake PRE-CREATION 
>   src/backends/CMakeLists.txt e27c84d 
>   src/backends/R/cantor_r.knsrc 02f9a1e 
>   src/backends/kalgebra/cantor_kalgebra.knsrc d0103eb 
>   src/backends/lua/cantor_lua.knsrc 25165d0 
>   src/backends/maxima/cantor_maxima.knsrc 7cccce8 
>   src/backends/octave/cantor_octave.knsrc 735739a 
>   src/backends/python/pythonbackend.cpp 3f66f39 
>   src/backends/python/pythonexpression.cpp 883c3ea 
>   src/backends/python/pythonsession.cpp c252572 
>   src/backends/python/pythonutils.h PRE-CREATION 
>   src/backends/python2/CMakeLists.txt 260c2f0 
>   src/backends/python2/cantor_python2.knsrc 7ec699c 
>   src/backends/python3/CMakeLists.txt PRE-CREATION 
>   src/backends/python3/cantor_python3.knsrc PRE-CREATION 
>   src/backends/python3/python3backend.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121374/diff/
> 
> 
> Testing
> -------
> 
> 1)
> a = 1
> b = 2
> print(a + b)
> 
> 2)
> import numpy as np
> a = np.array([1, 2, 3])
> print(a)
> 
> 
> Thanks,
> 
> Minh Ngo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141213/3f41e1aa/attachment-0001.html>