Review Request 121432: change in main.qml

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121432/#review71711
-----------------------------------------------------------


T


src/kanagram.kcfg
<https://git.reviewboard.kde.org/r/121432/#comment49999>

    please use camel case for new settings also.



src/kanagramgame.h
<https://git.reviewboard.kde.org/r/121432/#comment50000>

    As Inge pointed out, camel case here to be consistent with the other functions please.



src/kanagramgame.h
<https://git.reviewboard.kde.org/r/121432/#comment50001>

    Camel case here also please.



src/kanagramgame.cpp
<https://git.reviewboard.kde.org/r/121432/#comment50002>

    Same here



src/kanagramgame.cpp
<https://git.reviewboard.kde.org/r/121432/#comment50004>

    And here.



src/kanagramgame.cpp
<https://git.reviewboard.kde.org/r/121432/#comment50003>

    And here.



src/ui/main.qml
<https://git.reviewboard.kde.org/r/121432/#comment50005>

    Please use a more descriptive name than opi. Maybe something like singlePlayerButton or something?



src/ui/main.qml
<https://git.reviewboard.kde.org/r/121432/#comment50006>

    Same here, maybe playerModeText or something to make it more obvious what it is.


This looks pretty good other than the naming inconsistencies I've noted.

- Jeremy Whiting


On Dec. 10, 2014, 7:44 a.m., Souvik  Das wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121432/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 7:44 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kanagram
> 
> 
> Description
> -------
> 
> Icon toggle code in main.qml
> 
> 
> Diffs
> -----
> 
>   src/kanagram.kcfg 468e316528c413b8dc42d2e9d365b6fe63c63257 
>   src/kanagramgame.h e9564cfcc6a19a3ed5e63db5340cd19a760914d5 
>   src/kanagramgame.cpp e0b60866ef49af3f28161c72982b17c6865f88ef 
>   src/ui/icons/1player.png PRE-CREATION 
>   src/ui/icons/2player.png PRE-CREATION 
>   src/ui/main.qml 38408ae66772a578a45faeb92ff9828f7c174f2a 
> 
> Diff: https://git.reviewboard.kde.org/r/121432/diff/
> 
> 
> Testing
> -------
> 
> lines 71-116 are inserted to have an image which will show the current player mode (1player or 2player) and will act as a toggle button, when clicked, to change in between the two modes, and hence changing the icon. The toggling icon part is done by with, in this review.
> 
> 
> Thanks,
> 
> Souvik  Das
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141210/fde4ecb1/attachment.html>