Review Request 121430: change in main.qml

Souvik Das souvikdas728 at gmail.com
Wed Dec 10 14:14:15 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121430/
-----------------------------------------------------------

(Updated Dec. 10, 2014, 2:14 p.m.)


Review request for KDE Edu.


Repository: kanagram


Description (updated)
-------

lines 71-116 are inserted to have an image which will show the current player mode (1player or 2player) and will act as a toggle button, when clicked, to change in between the two modes, and hence changing the icon. The toggling icon part is done by with, in this review.


Diffs
-----

  src/kanagram.kcfg 468e316528c413b8dc42d2e9d365b6fe63c63257 
  src/kanagramgame.h e9564cfcc6a19a3ed5e63db5340cd19a760914d5 
  src/kanagramgame.cpp e0b60866ef49af3f28161c72982b17c6865f88ef 
  src/kanagramgame.h~ PRE-CREATION 
  src/mainwindow.cpp e1432562cdaff022b0f863bfbe72bf4abddbbc65 
  src/ui/icons/1player.png PRE-CREATION 
  src/ui/icons/2player.png PRE-CREATION 
  src/ui/main.qml 38408ae66772a578a45faeb92ff9828f7c174f2a 

Diff: https://git.reviewboard.kde.org/r/121430/diff/


Testing
-------


Thanks,

Souvik  Das

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141210/f86e3865/attachment.html>


More information about the kde-edu mailing list