Review Request 121327: fix ecm_install_icons usage and icon names

Marco Martin notmart at gmail.com
Tue Dec 2 13:46:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121327/#review71251
-----------------------------------------------------------

Ship it!


Inviala!

- Marco Martin


On Dic. 2, 2014, 12:51 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121327/
> -----------------------------------------------------------
> 
> (Updated Dic. 2, 2014, 12:51 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kdeedu-data
> 
> 
> Description
> -------
> 
> it requires an explicit list of icons nowadays. and the original icon names
> said *-action-* where *-actions-* should have been used.
> 
> this resolves 3000 warnings pertaining to the incorrect usage and names
> 
> 
> Diffs
> -----
> 
>   icons/hi32-action-newfunction.png  
>   icons/hi32-action-newimplicit.png  
>   icons/hi32-action-maximum.png  
>   icons/hi32-action-minimum.png  
>   icons/hi32-action-newdifferential.png  
>   icons/hi32-action-lessen.png  
>   icons/hi32-action-magnify.png  
>   icons/hi16-action-newimplicit.png  
>   icons/hi16-action-newparametric.png  
>   icons/hi16-action-newpolar.png  
>   icons/hi16-action-resetview.png  
>   icons/hi22-action-editplots.png  
>   icons/hi22-action-functionhelp.png  
>   icons/hi22-action-maximum.png  
>   icons/hi22-action-minimum.png  
>   icons/hi22-action-newdifferential.png  
>   icons/hi22-action-newfunction.png  
>   icons/hi22-action-newimplicit.png  
>   icons/hi22-action-newparametric.png  
>   icons/hi22-action-newpolar.png  
>   icons/hi32-action-func.png  
>   icons/hi32-action-functionhelp.png  
>   icons/hi32-action-integral_func.png  
>   icons/hi32-action-editconstants.png  
>   icons/hi32-action-editplots.png  
>   icons/hi22-action-resetview.png  
>   icons/hi32-action-coords.png  
>   icons/hi32-action-deriv_func.png  
>   icons/hi16-action-newdifferential.png  
>   icons/hi16-action-newfunction.png  
>   icons/hi16-action-integral_func.png  
>   icons/hi16-action-maximum.png  
>   icons/hi16-action-minimum.png  
>   icons/CMakeLists.txt 4b820aeb3820a1f5ee44f7b2266f3b9fb2df5f8e 
>   icons/hi16-action-editplots.png  
>   icons/hi16-action-functionhelp.png  
>   icons/hi48-action-resetview.png  
>   icons/hi64-action-maximum.png  
>   icons/hi64-action-minimum.png  
>   icons/hisc-action-deriv_func.svgz  
>   icons/hisc-action-editconstants.svgz  
>   icons/hisc-action-editplots.svgz  
>   icons/hisc-action-functionhelp.svgz  
>   icons/hisc-action-integral_func.svgz  
>   icons/hisc-action-maximum.svgz  
>   icons/hisc-action-minimum.svgz  
>   icons/hisc-action-newfunction.svgz  
>   icons/hisc-action-newparametric.svgz  
>   icons/hisc-action-newpolar.svgz  
>   icons/hisc-action-resetview.svgz  
>   icons/hi32-action-resetview.png  
>   icons/hi48-action-editplots.png  
>   icons/hi48-action-functionhelp.png  
>   icons/hi48-action-maximum.png  
>   icons/hi48-action-minimum.png  
>   icons/hi48-action-newdifferential.png  
>   icons/hi48-action-newfunction.png  
>   icons/hi48-action-newimplicit.png  
>   icons/hi48-action-newparametric.png  
>   icons/hi48-action-newpolar.png  
>   icons/hi32-action-newparametric.png  
>   icons/hi32-action-newpolar.png  
> 
> Diff: https://git.reviewboard.kde.org/r/121327/diff/
> 
> 
> Testing
> -------
> 
> built, installed, paths look fine
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141202/0bafdf62/attachment.html>


More information about the kde-edu mailing list